Tom Lane 65048cf23d Fix pg_dump/pg_restore to emit REFRESH MATERIALIZED VIEW commands last. ... Because we push all ACL (i.e. GRANT/REVOKE) restore steps to the end, materialized view refreshes were occurring while the permissions on referenced objects were still at defaults. This led to failures if, say, an MV owned by user A reads from a table owned by user B, even if B had granted the necessary privileges to A. We've had multiple complaints about that type of restore failure, most recently from Jordan Gigov. The ideal fix for this would be to start treating ACLs as dependency- sortable objects, rather than hard-wiring anything about their dump order (the existing approach is a messy kluge dating to commit dc0e76ca3). But that's going to be a rather major change, and it certainly wouldn't lead to a back-patchable fix. As a short-term solution, convert the existing two-pass hack (ie, normal objects then ACLs) to a three-pass hack, ie, normal objects then ACLs then matview refreshes. Because this happens in RestoreArchive(), it will also fix the problem when restoring from an existing archive-format dump. (Note this means that if a matview refresh would have failed under the permissions prevailing at dump time, it'll fail during restore as well. We'll define that as user error rather than something we should try to work around.) To avoid performance loss in parallel restore, we need the matview refreshes to still be parallelizable. Hence, clean things up enough so that both ACLs and matviews are handled by the parallel restore infrastructure, instead of reverting back to serial restore for ACLs. There is still a final serial step, but it shouldn't normally have to do anything; it's only there to try to recover if we get stuck due to some problem like unresolved circular dependencies. Patch by me, but it owes something to an earlier attempt by Kevin Grittner. Back-patch to 9.3 where materialized views were introduced. Discussion: https://postgr.es/m/28572.1500912583@sss.pgh.pa.us		2017-08-03 17:36:42 -04:00
..
backend	Add missing comment in postgresql.conf.	2017-07-31 11:28:19 +09:00
bin	Fix pg_dump/pg_restore to emit REFRESH MATERIALIZED VIEW commands last.	2017-08-03 17:36:42 -04:00
common	pgindent run for 9.5	2015-05-23 21:35:49 -04:00
include	Fix comment.	2017-08-01 08:08:47 +09:00
interfaces	Second try at fixing tcp_keepalives_idle option on Solaris.	2017-06-28 12:30:16 -04:00
makefiles	Always use -fPIC, not -fpic, when building shared libraries with gcc.	2017-06-01 13:32:56 -04:00
pl	PL/Perl portability fix: absorb relevant -D switches from Perl.	2017-07-31 12:38:35 -04:00
port	Stamp 9.5.7.	2017-05-08 17:17:18 -04:00
template	AIX: Test the -qlonglong option before use.	2015-07-17 03:01:29 -04:00
test	Ensure that pg_get_ruledef()'s output matches pg_get_viewdef()'s.	2017-07-24 15:16:31 -04:00
timezone	Fix new warnings from GCC 7	2017-05-16 08:43:55 -04:00
tools	Silence warning from modern perl about unescaped braces	2017-08-02 15:07:20 -04:00
tutorial	Remove no-longer-required function declarations.	2015-05-24 12:20:23 -04:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
bcc32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Install TAP test infrastructure so it's available for extension testing.	2016-09-23 15:50:00 -04:00
Makefile.global.in	PL/Perl portability fix: absorb relevant -D switches from Perl.	2017-07-31 12:38:35 -04:00
Makefile.shlib	Fix typos in comments.	2017-02-06 11:34:18 +02:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00
win32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00