mirror of
https://github.com/postgres/postgres.git
synced 2026-03-13 22:28:01 -04:00
e837718804
The deadlocks that the recovery conflict on lock is involved in can
happen between hot-standby backends and the startup process.
If a backend takes an access exclusive lock on the table and which
finally triggers the deadlock, that deadlock can be detected
as expected. On the other hand, previously, if the startup process
took an access exclusive lock and which finally triggered the deadlock,
that deadlock could not be detected and could remain even after
deadlock_timeout passed. This is a bug.
The cause of this bug was that the code for handling the recovery
conflict on lock didn't take care of deadlock case at all. It assumed
that deadlocks involving the startup process and backends were able
to be detected by the deadlock detector invoked within backends.
But this assumption was incorrect. The startup process also should
have invoked the deadlock detector if necessary.
To fix this bug, this commit makes the startup process invoke
the deadlock detector if deadlock_timeout is reached while handling
the recovery conflict on lock. Specifically, in that case, the startup
process requests all the backends holding the conflicting locks to
check themselves for deadlocks.
Back-patch to v9.6. v9.5 has also this bug, but per discussion we decided
not to back-patch the fix to v9.5. Because v9.5 doesn't have some
infrastructure codes (e.g.,
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| backendid.h | ||
| barrier.h | ||
| block.h | ||
| buf.h | ||
| buf_internals.h | ||
| buffile.h | ||
| bufmgr.h | ||
| bufpage.h | ||
| checksum.h | ||
| checksum_impl.h | ||
| condition_variable.h | ||
| copydir.h | ||
| dsm.h | ||
| dsm_impl.h | ||
| fd.h | ||
| freespace.h | ||
| fsm_internals.h | ||
| indexfsm.h | ||
| ipc.h | ||
| item.h | ||
| itemid.h | ||
| itemptr.h | ||
| large_object.h | ||
| latch.h | ||
| lmgr.h | ||
| lock.h | ||
| lockdefs.h | ||
| lwlock.h | ||
| off.h | ||
| pg_sema.h | ||
| pg_shmem.h | ||
| pmsignal.h | ||
| predicate.h | ||
| predicate_internals.h | ||
| proc.h | ||
| procarray.h | ||
| proclist.h | ||
| proclist_types.h | ||
| procsignal.h | ||
| reinit.h | ||
| relfilenode.h | ||
| s_lock.h | ||
| sharedfileset.h | ||
| shm_mq.h | ||
| shm_toc.h | ||
| shmem.h | ||
| sinval.h | ||
| sinvaladt.h | ||
| smgr.h | ||
| spin.h | ||
| standby.h | ||
| standbydefs.h | ||