mirror of
https://github.com/postgres/postgres.git
synced 2026-02-12 07:13:09 -05:00
When trying to use a high number of jobs, vacuumdb (and more recently reindexdb) has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections to Postgres. This commit changes the error handling so as we do not check anymore for a maximum number of allowed jobs when parsing the option value with FD_SETSIZE, but check instead if a file descriptor is within the supported range when opening the connections for the jobs so as this is detected at the earliest time possible. Also, improve the error message to give a hint about the number of jobs recommended, using a wording given by the reviewers of the patch. Reported-by: Andres Freund Author: Michael Paquier Reviewed-by: Andres Freund, Álvaro Herrera, Tom Lane Discussion: https://postgr.es/m/20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.de Backpatch-through: 9.5
38 lines
1 KiB
C
38 lines
1 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* scripts_parallel.h
|
|
* Parallel support for bin/scripts/
|
|
*
|
|
* Copyright (c) 2003-2019, PostgreSQL Global Development Group
|
|
*
|
|
* src/bin/scripts/scripts_parallel.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef SCRIPTS_PARALLEL_H
|
|
#define SCRIPTS_PARALLEL_H
|
|
|
|
#include "libpq-fe.h"
|
|
|
|
|
|
typedef struct ParallelSlot
|
|
{
|
|
PGconn *connection; /* One connection */
|
|
bool isFree; /* Is it known to be idle? */
|
|
} ParallelSlot;
|
|
|
|
extern ParallelSlot *ParallelSlotsGetIdle(ParallelSlot *slots, int numslots);
|
|
|
|
extern ParallelSlot *ParallelSlotsSetup(const char *dbname, const char *host,
|
|
const char *port,
|
|
const char *username,
|
|
bool prompt_password,
|
|
const char *progname, bool echo,
|
|
PGconn *conn, int numslots);
|
|
|
|
extern void ParallelSlotsTerminate(ParallelSlot *slots, int numslots);
|
|
|
|
extern bool ParallelSlotsWaitCompletion(ParallelSlot *slots, int numslots);
|
|
|
|
|
|
#endif /* SCRIPTS_PARALLEL_H */
|