mirror of
https://github.com/postgres/postgres.git
synced 2026-02-18 01:59:53 -05:00
74a1a36d75
The majority of error exit cases in json_lex_string() failed to set lex->token_terminator, causing problems for the error context reporting code: it would see token_terminator less than token_start and do something more or less nuts. In v14 and up the end result could be as bad as a crash in report_json_context(). Older versions accidentally avoided that fate; but all versions produce error context lines that are far less useful than intended, because they'd stop at the end of the prior token instead of continuing to where the actually-bad input is. To fix, invent some macros that make it less notationally painful to do the right thing. Also add documentation about what the function is actually required to do; and in >= v14, add an assertion in report_json_context about token_terminator being sufficiently far advanced. Per report from Nikolay Shaplov. Back-patch to all supported versions. Discussion: https://postgr.es/m/7332649.x5DLKWyVIX@thinkpad-pgpro
262 lines
8.7 KiB
Text
262 lines
8.7 KiB
Text
--
|
|
-- encoding-sensitive tests for json and jsonb
|
|
--
|
|
-- We provide expected-results files for UTF8 (json_encoding.out)
|
|
-- and for SQL_ASCII (json_encoding_1.out). Skip otherwise.
|
|
SELECT getdatabaseencoding() NOT IN ('UTF8', 'SQL_ASCII')
|
|
AS skip_test \gset
|
|
\if :skip_test
|
|
\quit
|
|
\endif
|
|
SELECT getdatabaseencoding(); -- just to label the results files
|
|
getdatabaseencoding
|
|
---------------------
|
|
UTF8
|
|
(1 row)
|
|
|
|
-- first json
|
|
-- basic unicode input
|
|
SELECT '"\u"'::json; -- ERROR, incomplete escape
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT '"\u"'::json;
|
|
^
|
|
DETAIL: "\u" must be followed by four hexadecimal digits.
|
|
CONTEXT: JSON data, line 1: "\u"
|
|
SELECT '"\u00"'::json; -- ERROR, incomplete escape
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT '"\u00"'::json;
|
|
^
|
|
DETAIL: "\u" must be followed by four hexadecimal digits.
|
|
CONTEXT: JSON data, line 1: "\u00"
|
|
SELECT '"\u000g"'::json; -- ERROR, g is not a hex digit
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT '"\u000g"'::json;
|
|
^
|
|
DETAIL: "\u" must be followed by four hexadecimal digits.
|
|
CONTEXT: JSON data, line 1: "\u000g...
|
|
SELECT '"\u0000"'::json; -- OK, legal escape
|
|
json
|
|
----------
|
|
"\u0000"
|
|
(1 row)
|
|
|
|
SELECT '"\uaBcD"'::json; -- OK, uppercase and lower case both OK
|
|
json
|
|
----------
|
|
"\uaBcD"
|
|
(1 row)
|
|
|
|
-- handling of unicode surrogate pairs
|
|
select json '{ "a": "\ud83d\ude04\ud83d\udc36" }' -> 'a' as correct_in_utf8;
|
|
correct_in_utf8
|
|
----------------------------
|
|
"\ud83d\ude04\ud83d\udc36"
|
|
(1 row)
|
|
|
|
select json '{ "a": "\ud83d\ud83d" }' -> 'a'; -- 2 high surrogates in a row
|
|
ERROR: invalid input syntax for type json
|
|
DETAIL: Unicode high surrogate must not follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ud83d\ud83d...
|
|
select json '{ "a": "\ude04\ud83d" }' -> 'a'; -- surrogates in wrong order
|
|
ERROR: invalid input syntax for type json
|
|
DETAIL: Unicode low surrogate must follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ude04...
|
|
select json '{ "a": "\ud83dX" }' -> 'a'; -- orphan high surrogate
|
|
ERROR: invalid input syntax for type json
|
|
DETAIL: Unicode low surrogate must follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ud83dX...
|
|
select json '{ "a": "\ude04X" }' -> 'a'; -- orphan low surrogate
|
|
ERROR: invalid input syntax for type json
|
|
DETAIL: Unicode low surrogate must follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ude04...
|
|
--handling of simple unicode escapes
|
|
select json '{ "a": "the Copyright \u00a9 sign" }' as correct_in_utf8;
|
|
correct_in_utf8
|
|
---------------------------------------
|
|
{ "a": "the Copyright \u00a9 sign" }
|
|
(1 row)
|
|
|
|
select json '{ "a": "dollar \u0024 character" }' as correct_everywhere;
|
|
correct_everywhere
|
|
-------------------------------------
|
|
{ "a": "dollar \u0024 character" }
|
|
(1 row)
|
|
|
|
select json '{ "a": "dollar \\u0024 character" }' as not_an_escape;
|
|
not_an_escape
|
|
--------------------------------------
|
|
{ "a": "dollar \\u0024 character" }
|
|
(1 row)
|
|
|
|
select json '{ "a": "null \u0000 escape" }' as not_unescaped;
|
|
not_unescaped
|
|
--------------------------------
|
|
{ "a": "null \u0000 escape" }
|
|
(1 row)
|
|
|
|
select json '{ "a": "null \\u0000 escape" }' as not_an_escape;
|
|
not_an_escape
|
|
---------------------------------
|
|
{ "a": "null \\u0000 escape" }
|
|
(1 row)
|
|
|
|
select json '{ "a": "the Copyright \u00a9 sign" }' ->> 'a' as correct_in_utf8;
|
|
correct_in_utf8
|
|
----------------------
|
|
the Copyright © sign
|
|
(1 row)
|
|
|
|
select json '{ "a": "dollar \u0024 character" }' ->> 'a' as correct_everywhere;
|
|
correct_everywhere
|
|
--------------------
|
|
dollar $ character
|
|
(1 row)
|
|
|
|
select json '{ "a": "dollar \\u0024 character" }' ->> 'a' as not_an_escape;
|
|
not_an_escape
|
|
-------------------------
|
|
dollar \u0024 character
|
|
(1 row)
|
|
|
|
select json '{ "a": "null \u0000 escape" }' ->> 'a' as fails;
|
|
ERROR: unsupported Unicode escape sequence
|
|
DETAIL: \u0000 cannot be converted to text.
|
|
CONTEXT: JSON data, line 1: { "a": "null \u0000...
|
|
select json '{ "a": "null \\u0000 escape" }' ->> 'a' as not_an_escape;
|
|
not_an_escape
|
|
--------------------
|
|
null \u0000 escape
|
|
(1 row)
|
|
|
|
-- then jsonb
|
|
-- basic unicode input
|
|
SELECT '"\u"'::jsonb; -- ERROR, incomplete escape
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT '"\u"'::jsonb;
|
|
^
|
|
DETAIL: "\u" must be followed by four hexadecimal digits.
|
|
CONTEXT: JSON data, line 1: "\u"
|
|
SELECT '"\u00"'::jsonb; -- ERROR, incomplete escape
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT '"\u00"'::jsonb;
|
|
^
|
|
DETAIL: "\u" must be followed by four hexadecimal digits.
|
|
CONTEXT: JSON data, line 1: "\u00"
|
|
SELECT '"\u000g"'::jsonb; -- ERROR, g is not a hex digit
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT '"\u000g"'::jsonb;
|
|
^
|
|
DETAIL: "\u" must be followed by four hexadecimal digits.
|
|
CONTEXT: JSON data, line 1: "\u000g...
|
|
SELECT '"\u0045"'::jsonb; -- OK, legal escape
|
|
jsonb
|
|
-------
|
|
"E"
|
|
(1 row)
|
|
|
|
SELECT '"\u0000"'::jsonb; -- ERROR, we don't support U+0000
|
|
ERROR: unsupported Unicode escape sequence
|
|
LINE 1: SELECT '"\u0000"'::jsonb;
|
|
^
|
|
DETAIL: \u0000 cannot be converted to text.
|
|
CONTEXT: JSON data, line 1: "\u0000...
|
|
-- use octet_length here so we don't get an odd unicode char in the
|
|
-- output
|
|
SELECT octet_length('"\uaBcD"'::jsonb::text); -- OK, uppercase and lower case both OK
|
|
octet_length
|
|
--------------
|
|
5
|
|
(1 row)
|
|
|
|
-- handling of unicode surrogate pairs
|
|
SELECT octet_length((jsonb '{ "a": "\ud83d\ude04\ud83d\udc36" }' -> 'a')::text) AS correct_in_utf8;
|
|
correct_in_utf8
|
|
-----------------
|
|
10
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "\ud83d\ud83d" }' -> 'a'; -- 2 high surrogates in a row
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT jsonb '{ "a": "\ud83d\ud83d" }' -> 'a';
|
|
^
|
|
DETAIL: Unicode high surrogate must not follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ud83d\ud83d...
|
|
SELECT jsonb '{ "a": "\ude04\ud83d" }' -> 'a'; -- surrogates in wrong order
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT jsonb '{ "a": "\ude04\ud83d" }' -> 'a';
|
|
^
|
|
DETAIL: Unicode low surrogate must follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ude04...
|
|
SELECT jsonb '{ "a": "\ud83dX" }' -> 'a'; -- orphan high surrogate
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT jsonb '{ "a": "\ud83dX" }' -> 'a';
|
|
^
|
|
DETAIL: Unicode low surrogate must follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ud83dX...
|
|
SELECT jsonb '{ "a": "\ude04X" }' -> 'a'; -- orphan low surrogate
|
|
ERROR: invalid input syntax for type json
|
|
LINE 1: SELECT jsonb '{ "a": "\ude04X" }' -> 'a';
|
|
^
|
|
DETAIL: Unicode low surrogate must follow a high surrogate.
|
|
CONTEXT: JSON data, line 1: { "a": "\ude04...
|
|
-- handling of simple unicode escapes
|
|
SELECT jsonb '{ "a": "the Copyright \u00a9 sign" }' as correct_in_utf8;
|
|
correct_in_utf8
|
|
-------------------------------
|
|
{"a": "the Copyright © sign"}
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "dollar \u0024 character" }' as correct_everywhere;
|
|
correct_everywhere
|
|
-----------------------------
|
|
{"a": "dollar $ character"}
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "dollar \\u0024 character" }' as not_an_escape;
|
|
not_an_escape
|
|
-----------------------------------
|
|
{"a": "dollar \\u0024 character"}
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "null \u0000 escape" }' as fails;
|
|
ERROR: unsupported Unicode escape sequence
|
|
LINE 1: SELECT jsonb '{ "a": "null \u0000 escape" }' as fails;
|
|
^
|
|
DETAIL: \u0000 cannot be converted to text.
|
|
CONTEXT: JSON data, line 1: { "a": "null \u0000...
|
|
SELECT jsonb '{ "a": "null \\u0000 escape" }' as not_an_escape;
|
|
not_an_escape
|
|
------------------------------
|
|
{"a": "null \\u0000 escape"}
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "the Copyright \u00a9 sign" }' ->> 'a' as correct_in_utf8;
|
|
correct_in_utf8
|
|
----------------------
|
|
the Copyright © sign
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "dollar \u0024 character" }' ->> 'a' as correct_everywhere;
|
|
correct_everywhere
|
|
--------------------
|
|
dollar $ character
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "dollar \\u0024 character" }' ->> 'a' as not_an_escape;
|
|
not_an_escape
|
|
-------------------------
|
|
dollar \u0024 character
|
|
(1 row)
|
|
|
|
SELECT jsonb '{ "a": "null \u0000 escape" }' ->> 'a' as fails;
|
|
ERROR: unsupported Unicode escape sequence
|
|
LINE 1: SELECT jsonb '{ "a": "null \u0000 escape" }' ->> 'a' as fai...
|
|
^
|
|
DETAIL: \u0000 cannot be converted to text.
|
|
CONTEXT: JSON data, line 1: { "a": "null \u0000...
|
|
SELECT jsonb '{ "a": "null \\u0000 escape" }' ->> 'a' as not_an_escape;
|
|
not_an_escape
|
|
--------------------
|
|
null \u0000 escape
|
|
(1 row)
|
|
|