mirror of
https://github.com/postgres/postgres.git
synced 2026-04-15 22:10:45 -04:00
8b3e2c622a
There was a pg_isblank() function that claimed to be a replacement for the standard isblank() function, which was thought to be "not very portable yet". We can now assume that it's portable (it's in C99). But pg_isblank() actually diverged from the standard isblank() by also accepting '\r', while the standard one only accepts space and tab. This was added to support parsing pg_hba.conf under Windows. But the hba parsing code now works completely differently and already handles line endings before we get to pg_isblank(). The other user of pg_isblank() is for ident protocol message parsing, which also handles '\r' separately. So this behavior is now obsolete and confusing. To improve clarity, I separated those concerns. The ident parsing now gets its own function that hardcodes the whitespace characters mentioned by the relevant RFC. pg_isblank() is now static in hba.c and is a wrapper around the standard isblank(), with some extra logic to ensure robust treatment of non-ASCII characters. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/170308e6-a7a3-4484-87b2-f960bb564afa%40eisentraut.org |
||
|---|---|---|
| .. | ||
| auth.h | ||
| be-fsstubs.h | ||
| be-gssapi-common.h | ||
| crypt.h | ||
| hba.h | ||
| ifaddr.h | ||
| libpq-be-fe-helpers.h | ||
| libpq-be-fe.h | ||
| libpq-be.h | ||
| libpq-fs.h | ||
| libpq.h | ||
| oauth.h | ||
| pg-gssapi.h | ||
| pqcomm.h | ||
| pqformat.h | ||
| pqmq.h | ||
| pqsignal.h | ||
| protocol.h | ||
| sasl.h | ||
| scram.h | ||