mirror of
https://github.com/postgres/postgres.git
synced 2026-02-11 14:53:31 -05:00
2e517818f4
SPI_commit previously left it up to the caller to recover from any error occurring during commit. Since that's complicated and requires use of low-level xact.c facilities, it's not too surprising that no caller got it right. Let's move the responsibility for cleanup into spi.c. Doing that requires redefining SPI_commit as starting a new transaction, so that it becomes equivalent to SPI_commit_and_chain except that you get default transaction characteristics instead of preserving the prior transaction's characteristics. We can make this pretty transparent API-wise by redefining SPI_start_transaction() as a no-op. Callers that expect to do something in between might be surprised, but available evidence is that no callers do so. Having made that API redefinition, we can fix this mess by having SPI_commit[_and_chain] trap errors and start a new, clean transaction before re-throwing the error. Likewise for SPI_rollback[_and_chain]. Some cleanup is also needed in AtEOXact_SPI, which was nowhere near smart enough to deal with SPI contexts nested inside a committing context. While plperl and pltcl need no changes beyond removing their now-useless SPI_start_transaction() calls, plpython needs some more work because it hadn't gotten the memo about catching commit/rollback errors in the first place. Such an error resulted in longjmp'ing out of the Python interpreter, which leaks Python stack entries at present and is reported to crash Python 3.11 altogether. Add the missing logic to catch such errors and convert them into Python exceptions. We are probably going to have to back-patch this once Python 3.11 ships, but it's a sufficiently basic change that I'm a bit nervous about doing so immediately. Let's let it bake awhile in HEAD first. Peter Eisentraut and Tom Lane Discussion: https://postgr.es/m/3375ffd8-d71c-2565-e348-a597d6e739e3@enterprisedb.com Discussion: https://postgr.es/m/17416-ed8fe5d7213d6c25@postgresql.org |
||
|---|---|---|
| .. | ||
| plpython_call.out | ||
| plpython_composite.out | ||
| plpython_do.out | ||
| plpython_drop.out | ||
| plpython_ereport.out | ||
| plpython_error.out | ||
| plpython_error_5.out | ||
| plpython_global.out | ||
| plpython_import.out | ||
| plpython_newline.out | ||
| plpython_params.out | ||
| plpython_populate.out | ||
| plpython_quote.out | ||
| plpython_record.out | ||
| plpython_schema.out | ||
| plpython_setof.out | ||
| plpython_spi.out | ||
| plpython_subtransaction.out | ||
| plpython_test.out | ||
| plpython_transaction.out | ||
| plpython_trigger.out | ||
| plpython_types.out | ||
| plpython_types_3.out | ||
| plpython_unicode.out | ||
| plpython_void.out | ||
| README | ||
Guide to alternative expected files: plpython_error_5.out Python 3.5 and newer plpython_unicode.out server encoding != SQL_ASCII plpython_unicode_3.out server encoding == SQL_ASCII plpython_types_3.out Python 3.x