mirror of
https://github.com/postgres/postgres.git
synced 2026-04-14 13:37:39 -04:00
e9d723487b
The code removed here deleted already-used data from a partially-read
WAL segment's hashtable entry. The intent was evidently to try to
keep the entry's memory consumption below the WAL segment's total
size, but we don't use WAL segments that are so large as to make that
a big win. The important memory-space optimization is to remove
hashtable entries altogether when done with them, and that's handled
elsewhere. To buy that, we must accept a substantially more complex
(and under-documented) logical invariant about what is in entry->buf,
as well as complex and under-documented interactions with the entry
spilling logic, various re-checking code paths in xlogreader.c,
and pg_waldump's overall data processing order. Any of those aspects
could have bugs lurking still, and are quite likely to be prone to
new bugs after future code changes.
Given the number of bugs we've already found in commit
|
||
|---|---|---|
| .. | ||
| po | ||
| t | ||
| .gitignore | ||
| archive_waldump.c | ||
| compat.c | ||
| Makefile | ||
| meson.build | ||
| nls.mk | ||
| pg_waldump.c | ||
| pg_waldump.h | ||
| rmgrdesc.c | ||
| rmgrdesc.h | ||