Michael Paquier 86831952ad Ignore temporary relations in RelidByRelfilenumber() ... Temporary relations may share the same RelFileNumber with a permanent relation, or other temporary relations associated with other sessions. Being able to uniquely identify a temporary relation would require RelidByRelfilenumber() to know about the proc number of the temporary relation it wants to identify, something it is not designed for since its introduction in f01d1ae3a1. There are currently three callers of RelidByRelfilenumber(): - autoprewarm. - Logical decoding, reorder buffer. - pg_filenode_relation(), that attempts to find a relation OID based on a tablespace OID and a RelFileNumber. This makes the situation problematic particularly for the first two cases, leading to the possibility of random ERRORs due to inconsistencies that temporary relations can create in the cache maintained by RelidByRelfilenumber(). The third case should be less of an issue, as I suspect that there are few direct callers of pg_filenode_relation(). The window where the ERRORs are happen is very narrow, requiring an OID wraparound to create a lookup conflict in RelidByRelfilenumber() with a temporary table reusing the same OID as another relation already cached. The problem is easier to reach in workloads with a high OID consumption rate, especially with a higher number of temporary relations created. We could get pg_filenode_relation() and RelidByRelfilenumber() to work with temporary relations if provided the means to identify them with an optional proc number given in input, but the years have also shown that we do not have a use case for it, yet. Note that this could not be backpatched if pg_filenode_relation() needs changes. It is simpler to ignore temporary relations. Reported-by: Shenhao Wang <wangsh.fnst@fujitsu.com> Author: Vignesh C <vignesh21@gmail.com> Reviewed-By: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-By: Robert Haas <robertmhaas@gmail.com> Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Reviewed-By: Takamichi Osumi <osumi.takamichi@fujitsu.com> Reviewed-By: Michael Paquier <michael@paquier.xyz> Reviewed-By: Masahiko Sawada <sawada.mshk@gmail.com> Reported-By: Shenhao Wang <wangsh.fnst@fujitsu.com> Discussion: https://postgr.es/m/bbaaf9f9-ebb2-645f-54bb-34d6efc7ac42@fujitsu.com Backpatch-through: 13		2025-08-22 09:06:34 +09:00
..
backend	Ignore temporary relations in RelidByRelfilenumber()	2025-08-22 09:06:34 +09:00
bin	Restrict psql meta-commands in plain-text dumps.	2025-08-11 09:00:00 -05:00
common	Don't put library-supplied -L/-I switches before user-supplied ones.	2025-07-29 15:17:40 -04:00
fe_utils	Fix bug in archive streamer with LZ4 decompression	2025-07-02 13:48:41 +09:00
include	Update obsolete comments in ResultRelInfo struct.	2025-08-17 19:40:01 +09:00
interfaces	Translation updates	2025-08-11 14:38:06 +02:00
makefiles	pgxs.mk: remove unreachable rule for deleting regress.def.	2025-06-20 12:12:29 -04:00
pl	Translation updates	2025-08-11 14:38:06 +02:00
port	Fix indentation in pg_numa code	2025-07-01 15:24:19 +02:00
template	thread-safety: gmtime_r(), localtime_r()	2024-08-23 07:43:04 +02:00
test	Ignore temporary relations in RelidByRelfilenumber()	2025-08-22 09:06:34 +09:00
timezone	Update time zone data files to tzdata release 2025b.	2025-04-30 11:13:49 -04:00
tools	ci: Per-repo configuration for manually trigger tasks	2025-08-14 11:33:44 -04:00
tutorial	Doc: simplify the tutorial's window-function examples.	2025-01-21 14:43:21 -05:00
.gitignore
DEVELOPERS
Makefile	Remove distprep	2023-11-06 15:18:04 +01:00
Makefile.global.in	Don't put library-supplied -L/-I switches before user-supplied ones.	2025-07-29 15:17:40 -04:00
Makefile.shlib	Use exported symbols list on macOS for loadable modules as well	2025-06-10 07:04:43 +02:00
meson.build	Update copyright for 2025	2025-01-01 11:21:55 -05:00
nls-global.mk	Remove distprep	2023-11-06 15:18:04 +01:00