postgresql/src/backend
Noah Misch 582edc369c Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects.  Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser.  This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".

This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump().  If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear.  Users may fix such errors
by schema-qualifying affected names.  After upgrading, consider watching
server logs for these errors.

The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint.  That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.

Back-patch to 9.3 (all supported versions).

Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.

Security: CVE-2018-1058
2018-02-26 07:39:44 -08:00
..
access Use platform independent type for TupleTableSlot->tts_off. 2018-02-20 15:12:52 -08:00
bootstrap Allow UNIQUE indexes on partitioned tables 2018-02-19 17:40:00 -03:00
catalog Fix filtering of unsupported relations in logical replication 2018-02-23 22:13:21 -05:00
commands Support parameters in CALL 2018-02-22 21:36:48 -05:00
executor Fix brown-paper-bag bug in commit 0a459cec96. 2018-02-23 15:11:40 -05:00
foreign Remove bogus "extern" annotations on function definitions. 2018-02-19 12:07:44 -05:00
lib Remove some inappropriate #includes. 2018-02-16 12:14:08 -05:00
libpq Fix up references to scram-sha-256 2018-01-30 16:50:30 -05:00
main Update copyright for 2018 2018-01-02 23:30:12 -05:00
nodes Support parameters in CALL 2018-02-22 21:36:48 -05:00
optimizer Add a new upper planner relation for partially-aggregated results. 2018-02-26 09:32:32 -05:00
parser Support parameters in CALL 2018-02-22 21:36:48 -05:00
po Translation updates 2017-08-07 13:55:34 -04:00
port Support huge pages on Windows 2018-01-21 15:40:46 +01:00
postmaster Empty search_path in Autovacuum and non-psql/pgbench clients. 2018-02-26 07:39:44 -08:00
regex Update copyright for 2018 2018-01-02 23:30:12 -05:00
replication Fix filtering of unsupported relations in logical replication 2018-02-23 22:13:21 -05:00
rewrite Fix application of identity values in some cases 2018-02-02 14:39:10 -05:00
snowball Avoid unnecessary use of pg_strcasecmp for already-downcased identifiers. 2018-01-26 18:25:14 -05:00
statistics Update copyright for 2018 2018-01-02 23:30:12 -05:00
storage Remove extra words. 2018-02-22 18:06:30 -05:00
tcop Support parameters in CALL 2018-02-22 21:36:48 -05:00
tsearch Avoid unnecessary use of pg_strcasecmp for already-downcased identifiers. 2018-01-26 18:25:14 -05:00
utils Avoid using unsafe search_path settings during dump and restore. 2018-02-26 10:18:21 -05:00
.gitignore Add .gitignore entries for AIX-specific intermediate build artifacts. 2015-07-08 20:44:22 -04:00
common.mk Add ICU_CFLAGS to global CPPFLAGS 2017-06-12 15:57:22 -04:00
Makefile Update copyright for 2018 2018-01-02 23:30:12 -05:00
nls.mk Translation updates 2017-05-15 12:19:54 -04:00