postgresql/src/backend/utils
David Rowley 8b26769bc4 Fix an assortment of improper usages of string functions
In a similar effort to f736e188c and 110d81728, fixup various usages of
string functions where a more appropriate function is available and more
fit for purpose.

These changes include:

1. Use cstring_to_text_with_len() instead of cstring_to_text() when
   working with a StringInfoData and the length can easily be obtained.
2. Use appendStringInfoString() instead of appendStringInfo() when no
   formatting is required.
3. Use pstrdup(...) instead of psprintf("%s", ...)
4. Use pstrdup(...) instead of psprintf(...) (with no formatting)
5. Use appendPQExpBufferChar() instead of appendPQExpBufferStr() when the
   length of the string being appended is 1.
6. appendStringInfoChar() instead of appendStringInfo() when no formatting
   is required and string is 1 char long.
7. Use appendPQExpBufferStr(b, .) instead of appendPQExpBuffer(b, "%s", .)
8. Don't use pstrdup when it's fine to just point to the string constant.

I (David) did find other cases of #8 but opted to use #4 instead as I
wasn't certain enough that applying #8 was ok (e.g in hba.c)

Author: Ranier Vilela, David Rowley
Discussion: https://postgr.es/m/CAApHDvo2j2+RJBGhNtUz6BxabWWh2Jx16wMUMWKUjv70Ver1vg@mail.gmail.com
2022-09-06 13:19:44 +12:00
..
activity pgstat: Acquire lock when reading variable-numbered stats 2022-08-22 20:16:50 -07:00
adt Fix an assortment of improper usages of string functions 2022-09-06 13:19:44 +12:00
cache Make role grant system more consistent with other privileges. 2022-08-22 11:35:17 -04:00
error Clean up inconsistent use of fflush(). 2022-08-29 13:55:41 -04:00
fmgr Remove unnecessary casts in free() and pfree() 2022-08-26 15:55:57 +02:00
hash Update copyright for 2022 2022-01-07 19:04:57 -05:00
init Allow parallel workers to retrieve some data from Port 2022-08-24 12:57:13 +09:00
mb Update copyright for 2022 2022-01-07 19:04:57 -05:00
misc Build all Flex files standalone 2022-09-04 12:09:01 +07:00
mmgr Use MAXALIGN() in calculations using sizeof(SlabBlock) 2022-08-30 14:36:04 +12:00
resowner Fix incorrect uses of Datum conversion macros 2022-09-05 13:30:44 +02:00
sort Be smarter about freeing tuples during tuplesorts 2022-09-01 11:08:10 +12:00
time Optimize xid/subxid searches in XidInMVCCSnapshot(). 2022-08-11 09:17:42 +07:00
.gitignore Rearrange makefile rules for running Gen_fmgrtab.pl. 2018-05-03 17:54:18 -04:00
errcodes.txt Add another SQL/JSON error code 2022-07-18 14:26:43 +02:00
Gen_dummy_probes.pl Update copyright for 2022 2022-01-07 19:04:57 -05:00
Gen_dummy_probes.pl.prolog Update copyright for 2022 2022-01-07 19:04:57 -05:00
Gen_dummy_probes.sed Update copyright for 2022 2022-01-07 19:04:57 -05:00
Gen_fmgrtab.pl Update copyright for 2022 2022-01-07 19:04:57 -05:00
generate-errcodes.pl Add output file argument to generate-errcodes.pl 2022-07-18 12:24:35 -07:00
Makefile Clean up temp file from refactored dtrace rule 2022-07-19 07:31:58 +02:00
postprocess_dtrace.sed Refactor dtrace postprocessing make rules 2022-07-18 12:33:02 -07:00
probes.d Update copyright for 2022 2022-01-07 19:04:57 -05:00
README.Gen_dummy_probes Tweak generation of Gen_dummy_probes.pl 2021-05-11 20:02:02 -04:00

# Generating dummy probes

If Postgres isn't configured with dtrace enabled, we need to generate
dummy probes for the entries in probes.d, that do nothing.

This is accomplished in Unix via the sed script `Gen_dummy_probes.sed`. We
used to use this in MSVC builds using the perl utility `psed`, which mimicked
sed. However, that utility disappeared from Windows perl distributions and so
we converted the sed script to a perl script to be used in MSVC builds.

We still keep the sed script as the authoritative source for generating
these dummy probes because except on Windows perl is not a hard requirement
when building from a tarball.

So, if you need to change the way dummy probes are generated, first change
the sed script, and when it's working generate the perl script. This can
be accomplished by using the perl utility s2p.

s2p is no longer part of the perl core, so it might not be on your system,
but it is available on CPAN and also in many package systems. e.g.
on Fedora it can be installed using `cpan App::s2p` or
`dnf install perl-App-s2p`.

The Makefile contains a recipe for regenerating Gen_dummy_probes.pl, so all
you need to do is once you have s2p installed is `make Gen_dummy_probes.pl`
Note that in a VPATH build this will generate the file in the vpath tree,
not the source tree.