mirror of
https://github.com/postgres/postgres.git
synced 2026-04-09 02:56:13 -04:00
8f8bcb8883
We have in launch_backend.c:
/*
* The following need to be available to the save/restore_backend_variables
* functions. They are marked NON_EXEC_STATIC in their home modules.
*/
extern slock_t *ShmemLock;
extern slock_t *ProcStructLock;
extern PGPROC *AuxiliaryProcs;
extern PMSignalData *PMSignalState;
extern pg_time_t first_syslogger_file_time;
extern struct bkend *ShmemBackendArray;
extern bool redirection_done;
That comment is not completely true: ShmemLock, ShmemBackendArray, and
redirection_done are not in fact NON_EXEC_STATIC. ShmemLock once was,
but was then needed elsewhere. ShmemBackendArray was static inside
postmaster.c before launch_backend.c was created. redirection_done
was never static.
This patch moves the declaration of ShmemLock and redirection_done to
a header file.
ShmemBackendArray gets a NON_EXEC_STATIC. This doesn't make a
difference, since it only exists if EXEC_BACKEND anyway, but it makes
it consistent.
After that, the comment is now correct.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
|
||
|---|---|---|
| .. | ||
| autovacuum.c | ||
| auxprocess.c | ||
| bgworker.c | ||
| bgwriter.c | ||
| checkpointer.c | ||
| fork_process.c | ||
| interrupt.c | ||
| launch_backend.c | ||
| Makefile | ||
| meson.build | ||
| pgarch.c | ||
| postmaster.c | ||
| startup.c | ||
| syslogger.c | ||
| walsummarizer.c | ||
| walwriter.c | ||