mirror of
https://github.com/postgres/postgres.git
synced 2026-03-10 02:01:23 -04:00
If echo = false, simple_prompt() is supposed to prevent echoing the
input (for password input). However, the Windows implementation applied
the mode change to STD_INPUT_HANDLE. That would not have the desired
effect if stdin isn't actually the terminal, for instance if the user
is piping something into psql. Fix it to apply the mode change to
the correct input file, so that passwords do not echo in such cases.
In passing, shorten and de-uglify this code by using #elif rather than
an #if nest and removing some duplicated code.
Back-patch to all supported versions. To simplify that, also back-patch
the portions of commit
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| chklocale.c | ||
| crypt.c | ||
| dirent.c | ||
| dirmod.c | ||
| erand48.c | ||
| fls.c | ||
| fseeko.c | ||
| getaddrinfo.c | ||
| getopt.c | ||
| getopt_long.c | ||
| getpeereid.c | ||
| getrusage.c | ||
| gettimeofday.c | ||
| inet_aton.c | ||
| inet_net_ntop.c | ||
| isinf.c | ||
| kill.c | ||
| Makefile | ||
| mkdtemp.c | ||
| noblock.c | ||
| open.c | ||
| path.c | ||
| pg_crc32c_choose.c | ||
| pg_crc32c_sb8.c | ||
| pg_crc32c_sse42.c | ||
| pgcheckdir.c | ||
| pgmkdirp.c | ||
| pgsleep.c | ||
| pgstrcasecmp.c | ||
| pqsignal.c | ||
| pthread-win32.h | ||
| qsort.c | ||
| qsort_arg.c | ||
| quotes.c | ||
| random.c | ||
| README | ||
| rint.c | ||
| snprintf.c | ||
| sprompt.c | ||
| srandom.c | ||
| strerror.c | ||
| strlcat.c | ||
| strlcpy.c | ||
| system.c | ||
| tar.c | ||
| thread.c | ||
| unsetenv.c | ||
| win32.ico | ||
| win32env.c | ||
| win32error.c | ||
| win32setlocale.c | ||
| win32ver.rc | ||
src/port/README
libpgport
=========
libpgport must have special behavior. It supplies functions to both
libraries and applications. However, there are two complexities:
1) Libraries need to use object files that are compiled with exactly
the same flags as the library. libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries. This is done by removing -lpgport from the link line:
# Need to recompile any libpgport object files
LIBS := $(filter-out -lpgport, $(LIBS))
and adding infrastructure to recompile the object files:
OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
connect.o misc.o path.o exec.o \
$(filter snprintf.o, $(LIBOBJS))
The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.
2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first. This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq. libpq's libpgport usage changes over time, so such a
dependency is a problem. Win32, Linux, and Darwin use an export list to
control the symbols exported by libpq.