postgresql/contrib/pg_upgrade
Noah Misch 3db38b0cef Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects.  Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser.  This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".

This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump().  If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear.  Users may fix such errors
by schema-qualifying affected names.  After upgrading, consider watching
server logs for these errors.

The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint.  That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.

Back-patch to 9.3 (all supported versions).

Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.

Security: CVE-2018-1058
2018-02-26 07:39:48 -08:00
..
.gitignore Update .gitignore for pg_upgrade 2014-12-17 11:59:29 +01:00
check.c pg_upgrade: start/stop new server after pg_resetwal 2017-06-20 13:20:02 -04:00
controldata.c Fix spelling mistake. 2016-01-14 23:16:11 -05:00
dump.c Ensure that all temp files made during pg_upgrade are non-world-readable. 2018-02-05 10:58:27 -05:00
exec.c Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
file.c Ensure that all temp files made during pg_upgrade are non-world-readable. 2018-02-05 10:58:27 -05:00
function.c Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
IMPLEMENTATION Remove useless whitespace at end of lines 2010-11-23 22:34:55 +02:00
info.c pg_dump, pg_upgrade: allow postgres/template1 tablespace moves 2015-09-11 15:51:10 -04:00
Makefile Fix pg_dump to handle inherited NOT VALID check constraints correctly. 2015-10-01 16:19:49 -04:00
option.c Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
page.c Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
parallel.c pg_upgrade: clarify C comment about Windows thread struct pointers 2013-07-30 09:23:31 -04:00
pg_upgrade.c Repair pg_upgrade's failure to preserve relfrozenxid for matviews. 2018-02-21 18:40:24 -05:00
pg_upgrade.h Ensure that all temp files made during pg_upgrade are non-world-readable. 2018-02-05 10:58:27 -05:00
relfilenode.c Fix new warnings from GCC 7 2017-05-15 13:31:38 -04:00
server.c Empty search_path in Autovacuum and non-psql/pgbench clients. 2018-02-26 07:39:48 -08:00
tablespace.c pg_upgrade: throw an error for non-existent tablespace directories 2014-04-17 11:42:21 -04:00
test.sh Obstruct shell, SQL, and conninfo injection via database and role names. 2016-08-08 10:07:52 -04:00
TESTING Remove whitespace from end of lines 2012-05-15 22:19:41 +03:00
util.c Obstruct shell, SQL, and conninfo injection via database and role names. 2016-08-08 10:07:52 -04:00
version.c Obstruct shell, SQL, and conninfo injection via database and role names. 2016-08-08 10:07:52 -04:00
version_old_8_3.c Obstruct shell, SQL, and conninfo injection via database and role names. 2016-08-08 10:07:52 -04:00