mirror of
https://github.com/postgres/postgres.git
synced 2026-02-14 08:13:27 -05:00
4f49e4b55e
This fixes a poorly written integer comparison function which was performing subtraction in an attempt to return a negative value when a < b and a positive value when a > b, and 0 when the values were equal. Unfortunately that didn't always work correctly due to two's complement having the INT_MIN 1 further from zero than INT_MAX. This could result in an overflow and cause the comparison function to return an incorrect result, which would result in the binary search failing to find the value being searched for. This could cause poor selectivity estimates when the statistics stored the value of INT_MAX (2147483647) and the value being searched for was large enough to result in the binary search doing a comparison with that INT_MAX value. Author: Chao Li <li.evan.chao@gmail.com> Reviewed-by: David Rowley <dgrowleyml@gmail.com> Discussion: https://postgr.es/m/CAEoWx2ng1Ot5LoKbVU-Dh---dFTUZWJRH8wv2chBu29fnNDMaQ@mail.gmail.com Backpatch-through: 14 |
||
|---|---|---|
| .. | ||
| bench | ||
| data | ||
| expected | ||
| sql | ||
| .gitignore | ||
| _int.h | ||
| _int_bool.c | ||
| _int_gin.c | ||
| _int_gist.c | ||
| _int_op.c | ||
| _int_selfuncs.c | ||
| _int_tool.c | ||
| _intbig_gist.c | ||
| intarray--1.0--1.1.sql | ||
| intarray--1.1--1.2.sql | ||
| intarray--1.2--1.3.sql | ||
| intarray--1.2.sql | ||
| intarray--1.3--1.4.sql | ||
| intarray--1.4--1.5.sql | ||
| intarray.control | ||
| Makefile | ||
| meson.build | ||