postgresql/src/backend/nodes
Robert Haas fb1879c374 Fix parallel query so it doesn't spoil row estimates above Gather.
Commit 45be99f8cd removed GatherPath's
num_workers field, but this is entirely bogus.  Normally, a path's
parallel_workers flag is supposed to indicate the number of workers
that it wants, and should be 0 for a non-partial path.  In that
commit, I mistakenly thought that GatherPath could also use that field
to indicate the number of workers that it would try to start, but
that's disastrous, because then it can propagate up to higher nodes in
the plan tree, which will then get incorrect rowcounts because the
parallel_workers flag is involved in computing those values.  Repair
by putting the separate field back.

Report by Tomas Vondra.  Patch by me, reviewed by Amit Kapila.

Discussion: http://postgr.es/m/f91b4a44-f739-04bd-c4b6-f135bd643669@2ndquadrant.com
2017-03-31 21:10:30 -04:00
..
bitmapset.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
copyfuncs.c Fix improper repetition of previous results from a hashed aggregate. 2016-08-24 14:38:13 -04:00
equalfuncs.c Rethink node-level representation of partial-aggregation modes. 2016-06-26 14:33:38 -04:00
extensible.c Fix whitespace 2016-04-11 14:44:51 -04:00
list.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
Makefile Introduce extensible node types. 2016-02-12 09:38:11 -05:00
makefuncs.c Fix CREATE MATVIEW/CREATE TABLE AS ... WITH NO DATA to not plan the query. 2016-06-27 15:57:50 -04:00
nodeFuncs.c Rethink node-level representation of partial-aggregation modes. 2016-06-26 14:33:38 -04:00
nodes.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
outfuncs.c Fix parallel query so it doesn't spoil row estimates above Gather. 2017-03-31 21:10:30 -04:00
params.c Fix thinko in copyParamList. 2016-07-27 10:20:40 -04:00
print.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
read.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
readfuncs.c Fix improper repetition of previous results from a hashed aggregate. 2016-08-24 14:38:13 -04:00
README Fix various common mispellings. 2016-06-03 16:08:45 +01:00
tidbitmap.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
value.c Update copyright for 2016 2016-01-02 13:33:40 -05:00

src/backend/nodes/README

Node Structures
===============

Andrew Yu (11/94)

Introduction
------------

The current node structures are plain old C structures. "Inheritance" is
achieved by convention. No additional functions will be generated. Functions
that manipulate node structures reside in this directory.


FILES IN THIS DIRECTORY (src/backend/nodes/)

    General-purpose node manipulation functions:
	copyfuncs.c	- copy a node tree
	equalfuncs.c	- compare two node trees
	outfuncs.c	- convert a node tree to text representation
	readfuncs.c	- convert text representation back to a node tree
	makefuncs.c	- creator functions for some common node types
	nodeFuncs.c	- some other general-purpose manipulation functions

    Specialized manipulation functions:
	bitmapset.c	- Bitmapset support
	list.c		- generic list support
	params.c	- Param support
	tidbitmap.c	- TIDBitmap support
	value.c		- support for Value nodes

FILES IN src/include/nodes/

    Node definitions:
	nodes.h		- define node tags (NodeTag)
	primnodes.h	- primitive nodes
	parsenodes.h	- parse tree nodes
	plannodes.h	- plan tree nodes
	relation.h	- planner internal nodes
	execnodes.h	- executor nodes
	memnodes.h	- memory nodes
	pg_list.h	- generic list


Steps to Add a Node
-------------------

Suppose you want to define a node Foo:

1. Add a tag (T_Foo) to the enum NodeTag in nodes.h.  (If you insert the
   tag in a way that moves the numbers associated with existing tags,
   you'll need to recompile the whole tree after doing this.  It doesn't
   force initdb though, because the numbers never go to disk.)
2. Add the structure definition to the appropriate include/nodes/???.h file.
   If you intend to inherit from, say a Plan node, put Plan as the first field
   of your struct definition.
3. If you intend to use copyObject, equal, nodeToString or stringToNode,
   add an appropriate function to copyfuncs.c, equalfuncs.c, outfuncs.c
   and readfuncs.c accordingly.  (Except for frequently used nodes, don't
   bother writing a creator function in makefuncs.c)  The header comments
   in those files give general rules for whether you need to add support.
4. Add cases to the functions in nodeFuncs.c as needed.  There are many
   other places you'll probably also need to teach about your new node
   type.  Best bet is to grep for references to one or two similar existing
   node types to find all the places to touch.


Historical Note
---------------

Prior to the current simple C structure definitions, the Node structures
used a pseudo-inheritance system which automatically generated creator and
accessor functions. Since every node inherited from LispValue, the whole thing
was a mess. Here's a little anecdote:

    LispValue definition -- class used to support lisp structures
    in C.  This is here because we did not want to totally rewrite
    planner and executor code which depended on lisp structures when
    we ported postgres V1 from lisp to C. -cim 4/23/90