Tom Lane a0bbd012d9 Fix some minor postmaster-state-machine issues. ... In sigusr1_handler, don't ignore PMSIGNAL_ADVANCE_STATE_MACHINE based on pmState. The restriction is unnecessary (PostmasterStateMachine should work in any state), not future-proof (since it makes too many assumptions about why the signal might be sent), and broken even today because a race condition can make it necessary to respond to the signal in PM_WAIT_READONLY state. The race condition seems unlikely, but if it did happen, a hot-standby postmaster could fail to shut down after receiving a smart-shutdown request. In MaybeStartWalReceiver, don't clear the WalReceiverRequested flag if the fork attempt fails. Leaving it set allows us to try again in future iterations of the postmaster idle loop. (The startup process would eventually send a fresh request signal, but this change may allow us to retry the fork sooner.) Remove an obsolete comment and unnecessary test in PostmasterStateMachine's handling of PM_SHUTDOWN_2 state. It's not possible to have a live walreceiver in that state, and AFAICT has not been possible since commit 5e85315ea. This isn't a live bug, but the false comment is quite confusing to readers. In passing, rearrange sigusr1_handler's CheckPromoteSignal tests so that we don't uselessly perform stat() calls that we're going to ignore the results of. Add some comments clarifying the behavior of MaybeStartWalReceiver; I very nearly rearranged it in a way that'd reintroduce the race condition fixed in e5d494d78. Mea culpa for not commenting that properly at the time. Back-patch to all supported branches. The PMSIGNAL_ADVANCE_STATE_MACHINE change is the only one of even minor significance, but we might as well keep this code in sync across branches. Discussion: https://postgr.es/m/9001.1556046681@sss.pgh.pa.us		2019-04-24 14:15:44 -04:00
..
backend	Fix some minor postmaster-state-machine issues.	2019-04-24 14:15:44 -04:00
bin	Have pg_upgrade's Makefile honor NO_TEMP_INSTALL	2019-03-31 08:21:53 -04:00
common	Tolerate EINVAL when calling fsync() on a directory.	2019-02-24 23:52:20 +13:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	Fix detection of passwords hashed with MD5 or SCRAM-SHA-256	2019-04-23 15:43:38 +09:00
interfaces	Fix off-by-one check that can lead to a memory overflow in ecpg.	2019-04-11 21:05:39 +02:00
makefiles	Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds.	2019-04-09 08:25:42 -07:00
pl	Translation updates	2019-02-11 14:25:01 +01:00
port	Fix error handling of readdir() port implementation on first file lookup	2019-03-04 09:50:06 +09:00
template	Yet further rethinking of build changes for macOS Mojave.	2018-11-02 18:54:00 -04:00
test	Repair assorted issues in locale data extraction.	2019-04-23 18:51:31 -04:00
timezone	Update time zone data files to tzdata release 2018i.	2019-02-05 10:59:15 -05:00
tools	Consistently test for in-use shared memory.	2019-04-12 22:36:42 -07:00
tutorial	Phase 2 of pgindent updates.	2017-06-21 15:19:25 -04:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Build src/test/isolation during "make" and "make install".	2017-11-22 20:18:52 -08:00
Makefile.global.in	Consistently test for in-use shared memory.	2019-04-12 22:36:42 -07:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00