Tom Lane a1fb4bd856 Fix ts_headline() edge cases for empty query and empty search text. ... tsquery's GETQUERY() macro is only safe to apply to a tsquery that is known non-empty; otherwise it gives a pointer to garbage. Before commit 5a617d75d, ts_headline() avoided this pitfall, but only in a very indirect, nonobvious way. (hlCover could not reach its TS_execute call, because if the query contains no lexemes then hlFirstIndex would surely return -1.) After that commit, it fell into the trap, resulting in weird errors such as "unrecognized operator" and/or valgrind complaints. In HEAD, fix this by not calling TS_execute_locations() at all for an empty query. In the back branches, add a defensive check to hlCover() --- that's not fixing any live bug, but I judge the code a bit too fragile as-is. Also, both mark_hl_fragments() and mark_hl_words() were careless about the possibility of empty search text: in the cases where no match has been found, they'd end up telling mark_fragment() to mark from word indexes 0 to 0 inclusive, even when there is no word 0. This is harmless since we over-allocated the prs->words array, but it does annoy valgrind. Fix so that the end index is -1 and thus mark_fragment() will do nothing in such cases. Bottom line is that this fixes a live bug in HEAD, but in the back branches it's only getting rid of a valgrind nitpick. Back-patch anyway. Per report from Alexander Lakhin. Discussion: https://postgr.es/m/c27f642d-020b-01ff-ae61-086af287c4fd@gmail.com		2023-04-06 15:52:37 -04:00
..
backend	Fix ts_headline() edge cases for empty query and empty search text.	2023-04-06 15:52:37 -04:00
bin	Fix pg_dump for hash partitioning on enum columns.	2023-03-17 13:31:40 -04:00
common	Make EXEC_BACKEND more convenient on Linux and FreeBSD.	2023-02-08 13:09:52 +09:00
fe_utils	Clean up assorted failures under clang's -fsanitize=undefined checks.	2022-03-03 18:13:24 -05:00
include	Fix race in parallel hash join batch cleanup, take II.	2023-03-21 14:41:35 +13:00
interfaces	Fix inconsistent error handling for GSS encryption in PQconnectPoll()	2023-03-13 16:36:34 +09:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:35 -04:00
pl	Translation updates	2023-02-06 12:21:32 +01:00
port	Stamp 12.14.	2023-02-06 16:45:00 -05:00
template	On NetBSD, force dynamic symbol resolution at postmaster start.	2022-08-30 17:29:13 -04:00
test	Fix ts_headline() edge cases for empty query and empty search text.	2023-04-06 15:52:37 -04:00
timezone	Update time zone data files to tzdata release 2022g.	2023-01-31 17:37:28 -05:00
tools	Don't force SQL_ASCII/no-locale for installcheck in vcregress.pl	2023-02-26 06:52:09 -05:00
tutorial	Doc: sync src/tutorial/basics.source with SGML documentation.	2022-11-19 13:09:14 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Prevent port collisions between concurrent TAP tests	2022-11-22 10:52:42 -05:00
Makefile.shlib	Fix pkg-config files for static linking	2021-09-06 09:43:18 +02:00
nls-global.mk	NLS: Fix backend gettext triggers	2019-09-23 09:05:50 +02:00