Peter Geoghegan c00c54a9ac Fix nbtree pgstats accounting with parallel scans. ... Commit 5bf748b8, which enhanced nbtree ScalarArrayOp execution, made parallel index scans work with the new design for arrays via explicit scheduling of primitive index scans. Under this scheme a parallel index scan with array keys will perform the same number of index descents as an equivalent serial index scan (barring corner cases where an individual parallel worker discovers that it can advance the scan's array keys without anybody needing to perform another descent of the index to get to the relevant page on the leaf level). Despite all this, the pgstats accounting wasn't updated; it continued to increment the total number of index scans for the rel once per _bt_first call, no matter the details. As a result, the number of (primitive) index scans could be over-counted during parallel scans. To fix, delay incrementing the count of index scans until after we've established that another descent of the index (using either _bt_search or _bt_endpoint) is required. That way pg_stat_user_tables.idx_scan always advances in the same way, regardless of whether or not the scan makes use of parallelism. Oversight in commit 5bf748b8, which enhanced nbtree ScalarArrayOp execution. Author: Peter Geoghegan <pg@bowt.ie> Reviewed-By: Tomas Vondra <tomas@vondra.me> Discussion: https://postgr.es/m/CAH2-Wz=E7XrkvscBN0U6V81NK3Q-dQOmivvbEsjG-zwEfDdFpg@mail.gmail.com Discussion: https://postgr.es/m/CAH2-WzkRqvaqR2CTNqTZP0z6FuL4-3ED6eQB0yx38XBNj1v-4Q@mail.gmail.com Backpatch: 17-, where nbtree SAOP execution was enhanced.		2024-09-20 14:06:32 -04:00
..
backend	Fix nbtree pgstats accounting with parallel scans.	2024-09-20 14:06:32 -04:00
bin	Fix order of includes in src/bin/pg_upgrade/info.c	2024-09-19 14:34:00 +03:00
common	common/jsonapi: support libpq as a client	2024-09-11 09:01:07 +02:00
fe_utils	Prevent mis-encoding of "trailing junk after numeric literal" errors.	2024-09-05 12:42:33 -04:00
include	Move pg_wal_replay_wait() to xlogfuncs.c	2024-09-19 14:26:11 +03:00
interfaces	Add PQfullProtocolVersion() to surface the precise protocol version.	2024-09-09 11:54:55 -04:00
makefiles	Add -Wmissing-variable-declarations to the standard compilation flags	2024-08-03 11:51:02 +02:00
pl	Don't bother checking the result of SPI_connect[_ext] anymore.	2024-09-09 12:18:34 -04:00
port	Only perform pg_strong_random init when required	2024-09-02 13:52:27 +02:00
template	thread-safety: gmtime_r(), localtime_r()	2024-08-23 07:43:04 +02:00
test	Add parameter "connstr" to PostgreSQL::Test::Cluster::background_psql	2024-09-20 09:59:22 +09:00
timezone	Update time zone data files to tzdata release 2024a.	2024-02-01 15:57:53 -05:00
tools	Improve Perl script which adds commit links to release notes	2024-09-19 08:45:33 -04:00
tutorial	Update copyright for 2024	2024-01-03 20:49:05 -05:00
.gitignore
DEVELOPERS
Makefile	Remove distprep	2023-11-06 15:18:04 +01:00
Makefile.global.in	Add -Wmissing-variable-declarations to the standard compilation flags	2024-08-03 11:51:02 +02:00
Makefile.shlib	Remove AIX support	2024-02-28 15:17:23 +04:00
meson.build	Update copyright for 2024	2024-01-03 20:49:05 -05:00
nls-global.mk	Remove distprep	2023-11-06 15:18:04 +01:00