mirror of
https://github.com/postgres/postgres.git
synced 2026-02-13 07:43:11 -05:00
644b7d686e
Coverity complained that we weren't doing that, and it's right. This fix just makes fmtIdEnc() honor the general convention that OOM causes a PQExpBuffer to become marked "broken", without any immediate error. In the pretty-unlikely case that we actually did hit OOM here, the end result would be to return an empty string to the caller, probably resulting in invalid SQL syntax in an issued command (if nothing else went wrong, which is even more unlikely). It's tempting to throw an "out of memory" error if the buffer becomes broken, but there's not a lot of point in doing that only here and not in hundreds of other PQExpBuffer-using places in pg_dump and similar callers. The whole issue could do with some non-time-crunched redesign, perhaps. This is a followup to the fixes for CVE-2025-1094, and should be included if cherry-picking those fixes. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| archive.c | ||
| cancel.c | ||
| conditional.c | ||
| connect_utils.c | ||
| Makefile | ||
| mbprint.c | ||
| meson.build | ||
| option_utils.c | ||
| parallel_slot.c | ||
| print.c | ||
| psqlscan.l | ||
| query_utils.c | ||
| recovery_gen.c | ||
| simple_list.c | ||
| string_utils.c | ||