mirror of
https://github.com/postgres/postgres.git
synced 2026-03-01 12:50:55 -05:00
a8458f508a
Winsock only signals an FD_CLOSE event once if the other end of the
socket shuts down gracefully. Because each WaitLatchOrSocket() call
constructs and destroys a new event handle every time, with unlucky
timing we can lose it and hang. We get away with this only if the other
end disconnects non-gracefully, because FD_CLOSE is repeatedly signaled
in that case.
To fix this design flaw in our Windows socket support fundamentally,
we'd probably need to rearchitect it so that a single event handle
exists for the lifetime of a socket, or switch to completely different
multiplexing or async I/O APIs. That's going to be a bigger job
and probably wouldn't be back-patchable.
This brute force kludge closes the race by explicitly polling with
MSG_PEEK before sleeping.
Back-patch to all supported releases. This should hopefully clear up
some random build farm and CI hang failures reported over the years. It
might also allow us to try using graceful shutdown in more places again
(reverted in commit
|
||
|---|---|---|
| .. | ||
| aio | ||
| buffer | ||
| file | ||
| freespace | ||
| ipc | ||
| large_object | ||
| lmgr | ||
| page | ||
| smgr | ||
| sync | ||
| Makefile | ||
| meson.build | ||