mirror of
https://github.com/postgres/postgres.git
synced 2026-02-17 01:31:07 -05:00
081cf78d12
When decoding a TRUNCATE record, the relids array was being allocated in the main ReorderBuffer memory context, but not released with the change resulting in a memory leak. The array was also ignored when serializing/deserializing the change, assuming all the information is stored in the change itself. So when spilling the change to disk, we've only we have serialized only the pointer to the relids array. Thanks to never releasing the array, the pointer however remained valid even after loading the change back to memory, preventing an actual crash. This fixes both the memory leak and (de)serialization. The relids array is still allocated in the main ReorderBuffer memory context (none of the existing ones seems like a good match, and adding an extra context seems like an overkill). The allocation is wrapped in a new ReorderBuffer API functions, to keep the details within reorderbuffer.c, just like the other ReorderBufferGet methods do. Author: Tomas Vondra Discussion: https://www.postgresql.org/message-id/flat/66175a41-9342-2845-652f-1bd4c3ee50aa%402ndquadrant.com Backpatch: 11, where decoding of TRUNCATE was introduced |
||
|---|---|---|
| .. | ||
| basebackup.h | ||
| decode.h | ||
| logical.h | ||
| logicalfuncs.h | ||
| logicallauncher.h | ||
| logicalproto.h | ||
| logicalrelation.h | ||
| logicalworker.h | ||
| message.h | ||
| origin.h | ||
| output_plugin.h | ||
| pgoutput.h | ||
| reorderbuffer.h | ||
| slot.h | ||
| snapbuild.h | ||
| syncrep.h | ||
| walreceiver.h | ||
| walsender.h | ||
| walsender_private.h | ||
| worker_internal.h | ||