upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-05-21 09:48:06 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/include/replication
History
Masahiko Sawada b2ae077205 Fix re-distributing previously distributed invalidation messages during logical decoding. 
Commit 4909b38af0 introduced logic to distribute invalidation messages
from catalog-modifying transactions to all concurrent in-progress
transactions. However, since each transaction distributes not only its
original invalidation messages but also previously distributed
messages to other transactions, this leads to an exponential increase
in allocation request size for invalidation messages, ultimately
causing memory allocation failure.

This commit fixes this issue by tracking distributed invalidation
messages separately per decoded transaction and not redistributing
these messages to other in-progress transactions. The maximum size of
distributed invalidation messages that one transaction can store is
limited to MAX_DISTR_INVAL_MSG_PER_TXN (8MB). Once the size of the
distributed invalidation messages exceeds this threshold, we
invalidate all caches in locations where distributed invalidation
messages need to be executed.

Back-patch to all supported versions where we introduced the fix by
commit 4909b38af0.

Note that this commit adds two new fields to ReorderBufferTXN to store
the distributed transactions. This change breaks ABI compatibility in
back branches, affecting third-party extensions that depend on the
size of the ReorderBufferTXN struct, though this scenario seems
unlikely.

Additionally, it adds a new flag to the txn_flags field of
ReorderBufferTXN to indicate distributed invalidation message
overflow. This should not affect existing implementations, as it is
unlikely that third-party extensions use unused bits in the txn_flags
field.

Bug: #18938 #18942
Author: vignesh C <vignesh21@gmail.com>
Reported-by: Duncan Sands <duncan.sands@deepbluecap.com>
Reported-by: John Hutchins <john.hutchins@wicourts.gov>
Reported-by: Laurence Parry <greenreaper@hotmail.com>
Reported-by: Max Madden <maxmmadden@gmail.com>
Reported-by: Braulio Fdo Gonzalez <brauliofg@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://postgr.es/m/680bdaf6-f7d1-4536-b580-05c2760c67c6@deepbluecap.com
Discussion: https://postgr.es/m/18942-0ab1e5ae156613ad@postgresql.org
Discussion: https://postgr.es/m/18938-57c9a1c463b68ce0@postgresql.org
Discussion: https://postgr.es/m/CAD1FGCT2sYrP_70RTuo56QTizyc+J3wJdtn2gtO3VttQFpdMZg@mail.gmail.com
Discussion: https://postgr.es/m/CANO2=B=2BT1hSYCE=nuuTnVTnjidMg0+-FfnRnqM6kd23qoygg@mail.gmail.com
Backpatch-through: 13
2025-06-16 17:35:55 -07:00
..
decode.h Update copyright for 2023 2023-01-02 15:00:37 -05:00
logical.h Fix possibility of logical decoding partial transaction changes. 2024-07-11 22:48:18 +09:00
logicallauncher.h Track logrep apply workers' last start times to avoid useless waits. 2023-01-22 14:08:46 -05:00
logicalproto.h Fix the display of UNKNOWN message type in apply worker. 2023-07-25 09:01:29 +05:30
logicalrelation.h Remove unnecessary checks for indexes for REPLICA IDENTITY FULL tables. 2023-07-25 15:09:31 +09:00
logicalworker.h Perform apply of large transactions by parallel workers. 2023-01-09 07:52:45 +05:30
message.h Update copyright for 2023 2023-01-02 15:00:37 -05:00
origin.h Perform apply of large transactions by parallel workers. 2023-01-09 07:52:45 +05:30
output_plugin.h Fix some typos and some incorrectly duplicated words 2023-04-18 14:03:49 +12:00
pgoutput.h Perform apply of large transactions by parallel workers. 2023-01-09 07:52:45 +05:30
reorderbuffer.h Fix re-distributing previously distributed invalidation messages during logical decoding. 2025-06-16 17:35:55 -07:00
slot.h Support invalidating replication slots due to horizon and wal_level 2023-04-07 22:40:27 -07:00
snapbuild.h Update copyright for 2023 2023-01-02 15:00:37 -05:00
syncrep.h Update copyright for 2023 2023-01-02 15:00:37 -05:00
walreceiver.h Add new predefined role pg_create_subscription. 2023-03-30 11:37:19 -04:00
walsender.h For cascading replication, wake physical and logical walsenders separately 2023-04-08 01:06:00 -07:00
walsender_private.h Fix race with synchronous_standby_names at startup 2025-04-11 10:02:17 +09:00
worker_internal.h Fix invalid memory access during the shutdown of the parallel apply worker. 2023-05-09 09:28:06 +05:30