mirror of
https://github.com/postgres/postgres.git
synced 2026-03-07 07:40:31 -05:00
6aa44060a3
pg_authid's only varlena column is rolpassword, which unfortunately cannot be de-TOASTed during authentication because we haven't selected a database yet and cannot read pg_class. By removing pg_authid's TOAST table, attempts to set password hashes that require out-of-line storage will fail with a "row is too big" error instead. We may want to provide a more user-friendly error in the future, but for now let's just remove the useless TOAST table. Bumps catversion. Reported-by: Alexander Lakhin Reviewed-by: Tom Lane, Michael Paquier Discussion: https://postgr.es/m/89e8649c-eb74-db25-7945-6d6b23992394%40gmail.com
76 lines
2.5 KiB
SQL
76 lines
2.5 KiB
SQL
--
|
|
-- MISC_SANITY
|
|
-- Sanity checks for common errors in making system tables that don't fit
|
|
-- comfortably into either opr_sanity or type_sanity.
|
|
--
|
|
-- Every test failure in this file should be closely inspected.
|
|
-- The description of the failing test should be read carefully before
|
|
-- adjusting the expected output. In most cases, the queries should
|
|
-- not find *any* matching entries.
|
|
--
|
|
-- NB: run this test early, because some later tests create bogus entries.
|
|
|
|
|
|
-- **************** pg_depend ****************
|
|
|
|
-- Look for illegal values in pg_depend fields.
|
|
|
|
SELECT *
|
|
FROM pg_depend as d1
|
|
WHERE refclassid = 0 OR refobjid = 0 OR
|
|
classid = 0 OR objid = 0 OR
|
|
deptype NOT IN ('a', 'e', 'i', 'n', 'x', 'P', 'S');
|
|
|
|
|
|
-- **************** pg_shdepend ****************
|
|
|
|
-- Look for illegal values in pg_shdepend fields.
|
|
|
|
SELECT *
|
|
FROM pg_shdepend as d1
|
|
WHERE refclassid = 0 OR refobjid = 0 OR
|
|
classid = 0 OR objid = 0 OR
|
|
deptype NOT IN ('a', 'i', 'o', 'r', 't');
|
|
|
|
|
|
-- **************** pg_class ****************
|
|
|
|
-- Look for system tables with varlena columns but no toast table. All
|
|
-- system tables with toastable columns should have toast tables, with
|
|
-- the following exceptions:
|
|
-- 1. pg_class and pg_attribute, due to fear of recursive dependencies as
|
|
-- toast tables depend on them.
|
|
-- 2. pg_largeobject and pg_largeobject_metadata. Large object catalogs
|
|
-- and toast tables are mutually exclusive and large object data is handled
|
|
-- as user data by pg_upgrade, which would cause failures.
|
|
-- 3. pg_authid, since its toast table cannot be accessed when it would be
|
|
-- needed, i.e., during authentication before we've selected a database.
|
|
|
|
SELECT relname, attname, atttypid::regtype
|
|
FROM pg_class c JOIN pg_attribute a ON c.oid = attrelid
|
|
WHERE c.oid < 16384 AND
|
|
reltoastrelid = 0 AND
|
|
relkind = 'r' AND
|
|
attstorage != 'p'
|
|
ORDER BY 1, 2;
|
|
|
|
|
|
-- system catalogs without primary keys
|
|
--
|
|
-- Current exceptions:
|
|
-- * pg_depend, pg_shdepend don't have a unique key
|
|
SELECT relname
|
|
FROM pg_class
|
|
WHERE relnamespace = 'pg_catalog'::regnamespace AND relkind = 'r'
|
|
AND pg_class.oid NOT IN (SELECT indrelid FROM pg_index WHERE indisprimary)
|
|
ORDER BY 1;
|
|
|
|
|
|
-- system catalog unique indexes not wrapped in a constraint
|
|
-- (There should be none.)
|
|
SELECT relname
|
|
FROM pg_class c JOIN pg_index i ON c.oid = i.indexrelid
|
|
WHERE relnamespace = 'pg_catalog'::regnamespace AND relkind = 'i'
|
|
AND i.indisunique
|
|
AND c.oid NOT IN (SELECT conindid FROM pg_constraint)
|
|
ORDER BY 1;
|