Tom Lane b994c57a80 Fix CLUSTER/VACUUM FULL for toast values owned by recently-updated rows. ... In commit 7b0d0e9356, I made CLUSTER and VACUUM FULL try to preserve toast value OIDs from the original toast table to the new one. However, if we have to copy both live and recently-dead versions of a row that has a toasted column, those versions may well reference the same toast value with the same OID. The patch then led to duplicate-key failures as we tried to insert the toast value twice with the same OID. (The previous behavior was not very desirable either, since it would have silently inserted the same value twice with different OIDs. That wastes space, but what's worse is that the toast values inserted for already-dead heap rows would not be reclaimed by subsequent ordinary VACUUMs, since they go into the new toast table marked live not deleted.) To fix, check if the copied OID already exists in the new toast table, and if so, assume that it stores the desired value. This is reasonably safe since the only case where we will copy an OID from a previous toast pointer is when toast_insert_or_update was given that toast pointer and so we just pulled the data from the old table; if we got two different values that way then we have big problems anyway. We do have to assume that no other backend is inserting items into the new toast table concurrently, but that's surely safe for CLUSTER and VACUUM FULL. Per bug #6393 from Maxim Boguk. Back-patch to 9.0, same as the previous patch.		2012-01-12 16:40:19 -05:00
..
backend	Fix CLUSTER/VACUUM FULL for toast values owned by recently-updated rows.	2012-01-12 16:40:19 -05:00
bin	Fix pg_restore's direct-to-database mode for INSERT-style table data.	2012-01-06 13:04:15 -05:00
include	Fix CLUSTER/VACUUM FULL for toast values owned by recently-updated rows.	2012-01-12 16:40:19 -05:00
interfaces	In ecpg removed old leftover check for given connection name.	2011-12-18 18:45:39 +01:00
makefiles	Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS.	2011-08-24 15:17:03 -04:00
pl	Fix breakage from earlier plperl fix.	2012-01-05 18:01:52 -05:00
port	Stamp 9.1.2.	2011-12-01 16:47:20 -05:00
template	Remove cvs keywords from all files.	2010-09-20 22:08:53 +02:00
test	Make executor's SELECT INTO code save and restore original tuple receiver.	2012-01-04 18:31:01 -05:00
timezone	Update time zone data files to tzdata release 2011n.	2011-11-30 11:48:21 -05:00
tools	Fix MSVC builds broken by xsubpp change	2011-11-27 01:23:00 -05:00
tutorial	Stamp copyrights for year 2011.	2011-01-01 13:18:15 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
bcc32.mak	Remove useless whitespace at end of lines	2010-11-23 22:34:55 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Fix some oversights in distprep and maintainer-clean targets.	2011-03-10 00:04:05 -05:00
Makefile.global.in	Make distprep and *clean build targets recurse into all subdirectories.	2011-07-03 13:55:27 -04:00
Makefile.shlib	Use single quotes in preference to double quotes for protecting pathnames.	2011-06-15 21:45:50 -04:00
nls-global.mk	Fix makefile logic to not break the build when xgettext is missing	2010-10-14 23:16:46 +03:00
win32.mak	Remove useless whitespace at end of lines	2010-11-23 22:34:55 +02:00