postgresql/contrib/amcheck
Tomas Vondra 0cf205e122 amcheck: Fix posting tree checks in gin_index_check()
Fix two issues in parent_key validation in posting trees:

* It's not enough to check stack->parentblk is valid to determine if the
  parentkey is valid. It's possible parentblk is set to a valid block
  number, but parentkey is invalid. So check parentkey directly.

* We don't need to invalidate parentkey for all child pages of the
  rightmost page. It's enough to invalidate it for the rightmost child
  only, which means we can check more cases (less false negatives).

Issues reported by Arseniy Mukhin, along with a proposed patch. Review
by Andrey M. Borodin, cleanup and improvements by me.

Author: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
Reviewed-by: Andrey M. Borodin <x4mmm@yandex-team.ru>
Discussion: https://postgr.es/m/CAE7r3MJ611B9TE=YqBBncewp7-k64VWs+sjk7XF6fJUX77uFBA@mail.gmail.com
2025-06-17 16:48:11 +02:00
..
expected amcheck: Test gin_index_check on a multicolumn index 2025-06-17 14:14:54 +02:00
sql amcheck: Test gin_index_check on a multicolumn index 2025-06-17 14:14:54 +02:00
t amcheck: Fix posting tree checks in gin_index_check() 2025-06-17 16:48:11 +02:00
.gitignore Add .gitignore to contrib/amcheck. 2017-03-09 22:45:24 -05:00
amcheck--1.0--1.1.sql Add amcheck verification of heap relations belonging to btree indexes. 2018-03-31 19:52:01 -07:00
amcheck--1.0.sql Add amcheck extension to contrib. 2017-03-09 16:33:02 -08:00
amcheck--1.1--1.2.sql Allow amcheck to re-find tuples using new search. 2019-03-20 10:41:36 -07:00
amcheck--1.2--1.3.sql Extend amcheck to check heap pages. 2020-10-22 08:44:18 -04:00
amcheck--1.3--1.4.sql Teach contrib/amcheck to check the unique constraint violation 2023-10-28 00:21:23 +03:00
amcheck--1.4--1.5.sql amcheck: Add gin_index_check() to verify GIN index 2025-03-29 15:44:29 +01:00
amcheck.control amcheck: Add gin_index_check() to verify GIN index 2025-03-29 15:44:29 +01:00
Makefile amcheck: Add gin_index_check() to verify GIN index 2025-03-29 15:44:29 +01:00
meson.build amcheck: Fix checks of entry order for GIN indexes 2025-06-17 14:55:29 +02:00
verify_common.c amcheck: Move common routines into a separate module 2025-03-29 15:14:49 +01:00
verify_common.h Fix typos and grammar in the code 2025-04-19 19:17:42 +09:00
verify_gin.c amcheck: Fix posting tree checks in gin_index_check() 2025-06-17 16:48:11 +02:00
verify_heapam.c Fix a few duplicate words in comments 2025-04-21 10:41:18 +12:00
verify_nbtree.c amcheck: Move common routines into a separate module 2025-03-29 15:14:49 +01:00