mirror of
https://github.com/postgres/postgres.git
synced 2026-03-09 01:31:22 -04:00
8e5e3ff556
For many optional libraries, we extract the -L and -l switches needed
to link the library from a helper program such as llvm-config. In
some cases we put the resulting -L switches into LDFLAGS ahead of
-L switches specified via --with-libraries. That risks breaking
the user's intention for --with-libraries.
It's not such a problem if the library's -L switch points to a
directory containing only that library, but on some platforms a
library helper may "helpfully" offer a switch such as -L/usr/lib
that points to a directory holding all standard libraries. If the
user specified --with-libraries in hopes of overriding the standard
build of some library, the -L/usr/lib switch prevents that from
happening since it will come before the user-specified directory.
To fix, avoid inserting these switches directly into LDFLAGS during
configure, instead adding them to LIBDIRS or SHLIB_LINK. They will
still eventually get added to LDFLAGS, but only after the switches
coming from --with-libraries.
The same problem exists for -I switches: those coming from
--with-includes should appear before any coming from helper programs
such as llvm-config. We have not heard field complaints about this
case, but it seems certain that a user attempting to override a
standard library could have issues.
The changes for this go well beyond configure itself, however,
because many Makefiles have occasion to manipulate CPPFLAGS to
insert locally-desirable -I switches, and some of them got it wrong.
The correct ordering is any -I switches pointing at within-the-
source-tree-or-build-tree directories, then those from the tree-wide
CPPFLAGS, then those from helper programs. There were several places
that risked pulling in a system-supplied copy of libpq headers, for
example, instead of the in-tree files. (Commit
|
||
|---|---|---|
| .. | ||
| unicode | ||
| .gitignore | ||
| archive.c | ||
| base64.c | ||
| binaryheap.c | ||
| blkreftable.c | ||
| checksum_helper.c | ||
| compression.c | ||
| config_info.c | ||
| controldata_utils.c | ||
| cryptohash.c | ||
| cryptohash_openssl.c | ||
| d2s.c | ||
| d2s_full_table.h | ||
| d2s_intrinsics.h | ||
| digit_table.h | ||
| encnames.c | ||
| exec.c | ||
| f2s.c | ||
| fe_memutils.c | ||
| file_perm.c | ||
| file_utils.c | ||
| hashfn.c | ||
| hmac.c | ||
| hmac_openssl.c | ||
| ip.c | ||
| jsonapi.c | ||
| keywords.c | ||
| kwlookup.c | ||
| link-canary.c | ||
| logging.c | ||
| Makefile | ||
| md5.c | ||
| md5_common.c | ||
| md5_int.h | ||
| meson.build | ||
| parse_manifest.c | ||
| percentrepl.c | ||
| pg_get_line.c | ||
| pg_lzcompress.c | ||
| pg_prng.c | ||
| pgfnames.c | ||
| psprintf.c | ||
| relpath.c | ||
| restricted_token.c | ||
| rmtree.c | ||
| ryu_common.h | ||
| saslprep.c | ||
| scram-common.c | ||
| sha1.c | ||
| sha1_int.h | ||
| sha2.c | ||
| sha2_int.h | ||
| sprompt.c | ||
| string.c | ||
| stringinfo.c | ||
| unicode_case.c | ||
| unicode_category.c | ||
| unicode_norm.c | ||
| username.c | ||
| wait_error.c | ||
| wchar.c | ||