mirror of
https://github.com/postgres/postgres.git
synced 2026-03-02 21:30:36 -05:00
c66a7d75e6
Until now, when DROP DATABASE got interrupted in the wrong moment, the removal of the pg_database row would also roll back, even though some irreversible steps have already been taken. E.g. DropDatabaseBuffers() might have thrown out dirty buffers, or files could have been unlinked. But we continued to allow connections to such a corrupted database. To fix this, mark databases invalid with an in-place update, just before starting to perform irreversible steps. As we can't add a new column in the back branches, we use pg_database.datconnlimit = -2 for this purpose. An invalid database cannot be connected to anymore, but can still be dropped. Unfortunately we can't easily add output to psql's \l to indicate that some database is invalid, it doesn't fit in any of the existing columns. Add tests verifying that a interrupted DROP DATABASE is handled correctly in the backend and in various tools. Reported-by: Evgeny Morozov <postgresql3@realityexists.net> Author: Andres Freund <andres@anarazel.de> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/20230509004637.cgvmfwrbht7xm7p6@awork3.anarazel.de Discussion: https://postgr.es/m/20230314174521.74jl6ffqsee5mtug@awork3.anarazel.de Backpatch: 11-, bug present in all supported versions
43 lines
1.1 KiB
Perl
43 lines
1.1 KiB
Perl
|
|
# Copyright (c) 2021-2023, PostgreSQL Global Development Group
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use PostgreSQL::Test::Cluster;
|
|
use PostgreSQL::Test::Utils;
|
|
use Test::More;
|
|
|
|
program_help_ok('dropdb');
|
|
program_version_ok('dropdb');
|
|
program_options_handling_ok('dropdb');
|
|
|
|
my $node = PostgreSQL::Test::Cluster->new('main');
|
|
$node->init;
|
|
$node->start;
|
|
|
|
$node->safe_psql('postgres', 'CREATE DATABASE foobar1');
|
|
$node->issues_sql_like(
|
|
[ 'dropdb', 'foobar1' ],
|
|
qr/statement: DROP DATABASE foobar1/,
|
|
'SQL DROP DATABASE run');
|
|
|
|
$node->safe_psql('postgres', 'CREATE DATABASE foobar2');
|
|
$node->issues_sql_like(
|
|
[ 'dropdb', '--force', 'foobar2' ],
|
|
qr/statement: DROP DATABASE foobar2 WITH \(FORCE\);/,
|
|
'SQL DROP DATABASE (FORCE) run');
|
|
|
|
$node->command_fails([ 'dropdb', 'nonexistent' ],
|
|
'fails with nonexistent database');
|
|
|
|
# check that invalid database can be dropped with dropdb
|
|
$node->safe_psql(
|
|
'postgres', q(
|
|
CREATE DATABASE regression_invalid;
|
|
UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'regression_invalid';
|
|
));
|
|
$node->command_ok([ 'dropdb', 'regression_invalid' ],
|
|
'invalid database can be dropped');
|
|
|
|
done_testing();
|