mirror of
https://github.com/postgres/postgres.git
synced 2026-02-09 22:04:24 -05:00
e557c82759
If we're trying to perform check_function_bodies validation of a PL/Python trigger function, we create a new PLyProcedure, but we don't put it into the PLy_procedure_cache hash table. (Doing so would be useless, since we don't have the relation OID that is part of the cache key for a trigger function, so we could not make an entry that would be found by later uses.) However, we didn't think through what to do instead, with the result that the PLyProcedure was simply leaked. It would take a pretty large number of CREATE FUNCTION operations for this to amount to a serious problem, but it's easy to see the memory bloat if you do CREATE OR REPLACE FUNCTION in a loop. To fix, have PLy_procedure_get delete the new PLyProcedure and return NULL if it's not going to cache the PLyProcedure. I considered making plpython3_validator do the cleanup instead, which would be more natural. But then plpython3_validator would have to know the rules under which PLy_procedure_get returns a non-cached PLyProcedure, else it risks deleting something that's pointed to by a cache entry. On the whole it seems more robust to deal with the case inside PLy_procedure_get. Found by the new version of Coverity (nice catch!). In the end I feel this fix is more about satisfying Coverity than about fixing a real-world problem, so I'm not going to back-patch. |
||
|---|---|---|
| .. | ||
| expected | ||
| po | ||
| sql | ||
| .gitignore | ||
| generate-spiexceptions.pl | ||
| Makefile | ||
| meson.build | ||
| nls.mk | ||
| plpy_cursorobject.c | ||
| plpy_cursorobject.h | ||
| plpy_elog.c | ||
| plpy_elog.h | ||
| plpy_exec.c | ||
| plpy_exec.h | ||
| plpy_main.c | ||
| plpy_main.h | ||
| plpy_planobject.c | ||
| plpy_planobject.h | ||
| plpy_plpymodule.c | ||
| plpy_plpymodule.h | ||
| plpy_procedure.c | ||
| plpy_procedure.h | ||
| plpy_resultobject.c | ||
| plpy_resultobject.h | ||
| plpy_spi.c | ||
| plpy_spi.h | ||
| plpy_subxactobject.c | ||
| plpy_subxactobject.h | ||
| plpy_typeio.c | ||
| plpy_typeio.h | ||
| plpy_util.c | ||
| plpy_util.h | ||
| plpython.h | ||
| plpython3u--1.0.sql | ||
| plpython3u.control | ||
| plpython_system.h | ||