Tom Lane cb4c04a4e6 Fix parallel pg_dump/pg_restore for failure to create worker processes. ... If we failed to fork a worker process, or create a communication pipe for one, WaitForTerminatingWorkers would suffer an assertion failure if assert-enabled, otherwise crash or go into an infinite loop. This was a consequence of not accounting for the startup condition where we've not yet forked all the workers. The original bug was that ParallelBackupStart would set workerStatus to WRKR_IDLE before it had successfully forked a worker. I made things worse in commit b7b8cc0cf by not understanding the undocumented fact that the WRKR_TERMINATED state was also meant to represent the case where a worker hadn't been started yet: I changed enum T_WorkerStatus so that *all* the worker slots were initially in WRKR_IDLE state. But this wasn't any more broken in practice, since even one slot in the wrong state would keep WaitForTerminatingWorkers from terminating. In v10 and later, introduce an explicit T_WorkerStatus value for worker-not-started, in hopes of preventing future oversights of the same ilk. Before that, just document that WRKR_TERMINATED is supposed to cover that case (partly because it wasn't actively broken, and partly because the enum is exposed outside parallel.c in those branches, so there's microscopically more risk involved in changing it). In all branches, introduce a WORKER_IS_RUNNING status test macro to hide which T_WorkerStatus values mean that, and be more careful not to access ParallelSlot fields till we're sure they're valid. Per report from Vignesh C, though this is my patch not his. Back-patch to all supported branches. Discussion: https://postgr.es/m/CALDaNm1Luv-E3sarR+-unz-BjchquHHyfP+YC+2FS2pt_J+wxg@mail.gmail.com		2020-01-31 14:41:49 -05:00
..
backend	Make inherited TRUNCATE perform access permission checks on parent table only.	2020-01-31 00:45:39 +09:00
bin	Fix parallel pg_dump/pg_restore for failure to create worker processes.	2020-01-31 14:41:49 -05:00
common	Fix portability failure introduced in commits d2b0b60e7 et al.	2018-12-26 15:30:30 -05:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	Add GUC variables for stat tracking and timeout as PGDLLIMPORT	2020-01-21 13:47:10 +09:00
interfaces	libpq should expose GSS-related parameters even when not implemented.	2019-12-20 15:34:08 -05:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
pl	Translation updates	2019-11-11 10:27:46 +01:00
port	In pgwin32_open, loop after ERROR_ACCESS_DENIED only if we can't stat.	2019-12-21 17:39:36 -05:00
template	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
test	Make inherited TRUNCATE perform access permission checks on parent table only.	2020-01-31 00:45:39 +09:00
timezone	Update time zone data files to tzdata release 2019c.	2019-09-20 19:54:20 -04:00
tools	Handle spaces in OpenSSL install location for MSVC	2019-10-04 15:39:02 -04:00
tutorial	Update copyright for 2016	2016-01-02 13:33:40 -05:00
.gitignore
bcc32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00
DEVELOPERS
Makefile	Install TAP test infrastructure so it's available for extension testing.	2016-09-23 15:50:00 -04:00
Makefile.global.in	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00
win32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00