postgresql/src/port
Tom Lane cc7ea0717b pg_attribute_no_sanitize_alignment() macro
Modern gcc and clang compilers offer alignment sanitizers, which help to detect
pointer misalignment.  However, our codebase already contains x86-specific
crc32 computation code, which uses unalignment access.  Thankfully, those
compilers also support the attribute, which disables alignment sanitizers at
the function level.  This commit adds pg_attribute_no_sanitize_alignment(),
which wraps this attribute, and applies it to pg_comp_crc32c_sse42() function.

Back-patch of commits 993bdb9f9 and ad2ad698a, to enable doing
alignment testing in all supported branches.

Discussion: https://postgr.es/m/CAPpHfdsne3%3DT%3DfMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w%40mail.gmail.com
Discussion: https://postgr.es/m/475514.1612745257%40sss.pgh.pa.us
Author: Alexander Korotkov, revised by Tom Lane
Reviewed-by: Tom Lane
2021-02-13 17:49:08 -05:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
chklocale.c Be more careful about extracting encoding from locale strings on Windows. 2020-03-30 11:14:58 -04:00
crypt.c Suppress dead, unportable src/port/crypt.c code. 2014-10-12 23:27:06 -04:00
dirent.c Fix error handling of readdir() port implementation on first file lookup 2019-03-04 09:50:14 +09:00
dirmod.c Avoid possibly-unsafe use of Windows' FormatMessage() function. 2016-03-29 11:55:19 -04:00
erand48.c Redesign tablesample method API, and do extensive code review. 2015-07-25 14:39:00 -04:00
fls.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
fseeko.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
getaddrinfo.c Clean up assorted misuses of snprintf()'s result value. 2018-08-15 16:29:32 -04:00
getopt.c Use our own getopt() on OpenBSD. 2019-01-18 15:06:26 -05:00
getopt_long.c Fix our getopt_long's behavior for a command line argument of just "-". 2020-03-23 11:58:01 -04:00
getpeereid.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
getrusage.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
gettimeofday.c pgindent run for 9.5 2015-05-23 21:35:49 -04:00
inet_aton.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
inet_net_ntop.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
isinf.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
kill.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
Makefile Replace use of sys_siglist[] with strsignal(). 2020-07-15 22:05:13 -04:00
mkdtemp.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
noblock.c Avoid depending on non-POSIX behavior of fcntl(2). 2017-04-21 15:55:56 -04:00
open.c In pgwin32_open, loop after ERROR_ACCESS_DENIED only if we can't stat. 2019-12-21 17:39:36 -05:00
path.c Suppress GCC 6 warning about self-comparison 2016-03-08 19:41:51 -05:00
pg_crc32c_choose.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
pg_crc32c_sb8.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
pg_crc32c_sse42.c pg_attribute_no_sanitize_alignment() macro 2021-02-13 17:49:08 -05:00
pgcheckdir.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Include <sys/select.h> where needed 2016-09-27 01:05:21 -03:00
pgstrcasecmp.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
pgstrsignal.c Replace use of sys_siglist[] with strsignal(). 2020-07-15 22:05:13 -04:00
pqsignal.c In the postmaster, rely on the signal infrastructure to block signals. 2020-10-15 12:50:57 -04:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort.c Get rid of trailing semicolons in C macro definitions. 2020-05-01 17:28:01 -04:00
qsort_arg.c Get rid of trailing semicolons in C macro definitions. 2020-05-01 17:28:01 -04:00
quotes.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
random.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
README Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
rint.c Upgrade src/port/rint.c to be POSIX-compliant. 2015-03-25 15:54:18 -04:00
snprintf.c Set snprintf.c's maximum number of NL arguments to be 31. 2018-10-02 12:41:28 -04:00
sprompt.c Fix simple_prompt() to disable echo on Windows when stdin != terminal. 2018-05-23 19:04:34 -04:00
srandom.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
system.c Promote pg_dumpall shell/connstr quoting functions to src/fe_utils. 2016-08-08 10:07:46 -04:00
tar.c Adopt the GNU convention for handling tar-archive members exceeding 8GB. 2015-11-21 20:21:31 -05:00
thread.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
unsetenv.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Make pgwin32_putenv() visit debug CRTs. 2016-12-03 15:46:42 -05:00
win32error.c Update copyright for 2016 2016-01-02 13:33:40 -05:00
win32security.c Revert Windows service check refactoring, and replace with a different fix. 2017-03-24 12:39:23 +02:00
win32setlocale.c Deal with yet another issue related to "Norwegian (Bokmål)" locale. 2019-10-21 14:18:47 -04:00
win32ver.rc Stamp 9.6.21. 2021-02-08 17:01:30 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Win32, Linux, and Darwin use an export list to
control the symbols exported by libpq.