upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-04-06 01:35:56 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/backend/utils
History
Tom Lane 41b45576d5 Remove useless pfree()s at the ends of various ValuePerCall SRFs. 
We don't need to manually clean up allocations in a SRF's
multi_call_memory_ctx, because the SRF_RETURN_DONE infrastructure
takes care of that (and also ensures that it will happen even if the
function never gets a final call, which simple manual cleanup cannot
do).

Hence, the code removed by this patch is a waste of code and cycles.
Worse, it gives the impression that cleaning up manually is a thing,
which can lead to more serious errors such as those fixed in
commits 085b6b667 and b4570d33a.  So we should get rid of it.

These are not quite actual bugs though, so I couldn't muster the
enthusiasm to back-patch.  Fix in HEAD only.

Justin Pryzby

Discussion: https://postgr.es/m/20200308173103.GC1357@telsasoft.com
2020-03-16 21:36:53 -04:00
..
adt Remove useless pfree()s at the ends of various ValuePerCall SRFs. 2020-03-16 21:36:53 -04:00
cache Introduce a maintenance_io_concurrency setting. 2020-03-16 17:14:26 +13:00
error Add backend type to csvlog and optionally log_line_prefix 2020-03-15 11:20:21 +01:00
fmgr Avoid holding a directory FD open across assorted SRF calls. 2020-03-16 21:05:52 -04:00
hash Move src/backend/utils/hash/hashfn.c to src/common 2020-02-27 09:25:41 +05:30
init Unify several ways to tracking backend type 2020-03-13 14:01:10 +01:00
mb Marginal comments and docs cleanup. 2020-03-10 17:34:09 -04:00
misc Introduce a maintenance_io_concurrency setting. 2020-03-16 17:14:26 +13:00
mmgr Represent command completion tags as structs 2020-03-02 18:19:51 -03:00
resowner Move src/backend/utils/hash/hashfn.c to src/common 2020-02-27 09:25:41 +05:30
sort Introduce LogicalTapeSetExtend(). 2020-03-09 10:40:02 -07:00
time Update copyrights for 2020 2020-01-01 12:21:45 -05:00
.gitignore Rearrange makefile rules for running Gen_fmgrtab.pl. 2018-05-03 17:54:18 -04:00
errcodes.txt Update copyrights for 2020 2020-01-01 12:21:45 -05:00
Gen_dummy_probes.pl Update copyrights for 2020 2020-01-01 12:21:45 -05:00
Gen_dummy_probes.sed Update copyrights for 2020 2020-01-01 12:21:45 -05:00
Gen_fmgrtab.pl Update copyrights for 2020 2020-01-01 12:21:45 -05:00
generate-errcodes.pl Update copyrights for 2020 2020-01-01 12:21:45 -05:00
Makefile Update copyrights for 2020 2020-01-01 12:21:45 -05:00
probes.d Update copyrights for 2020 2020-01-01 12:21:45 -05:00