mirror of
https://github.com/postgres/postgres.git
synced 2026-02-27 11:50:33 -05:00
18555b1323
To ensure that "make installcheck" can be used safely against an existing installation, we need to be careful about what global object names (database, role, and tablespace names) we use; otherwise we might accidentally clobber important objects. There's been a weak consensus that test databases should have names including "regression", and that test role names should start with "regress_", but we didn't have any particular rule about tablespace names; and neither of the other rules was followed with any consistency either. This commit moves us a long way towards having a hard-and-fast rule that regression test databases must have names including "regression", and that test role and tablespace names must start with "regress_". It's not completely there because I did not touch some test cases in rolenames.sql that test creation of special role names like "session_user". That will require some rethinking of exactly what we want to test, whereas the intent of this patch is just to hit all the cases in which the needed renamings are cosmetic. There is no enforcement mechanism in this patch either, but if we don't add one we can expect that the tests will soon be violating the convention again. Again, that's not such a cosmetic change and it will require discussion. (But I did use a quick-hack enforcement patch to find these cases.) Discussion: <16638.1468620817@sss.pgh.pa.us>
97 lines
3.2 KiB
PL/PgSQL
97 lines
3.2 KiB
PL/PgSQL
CREATE FUNCTION alter_op_test_fn(boolean, boolean)
|
|
RETURNS boolean AS $$ SELECT NULL::BOOLEAN; $$ LANGUAGE sql IMMUTABLE;
|
|
|
|
CREATE FUNCTION customcontsel(internal, oid, internal, integer)
|
|
RETURNS float8 AS 'contsel' LANGUAGE internal STABLE STRICT;
|
|
|
|
CREATE OPERATOR === (
|
|
LEFTARG = boolean,
|
|
RIGHTARG = boolean,
|
|
PROCEDURE = alter_op_test_fn,
|
|
COMMUTATOR = ===,
|
|
NEGATOR = !==,
|
|
RESTRICT = customcontsel,
|
|
JOIN = contjoinsel,
|
|
HASHES, MERGES
|
|
);
|
|
|
|
SELECT pg_describe_object(refclassid,refobjid,refobjsubid) as ref, deptype
|
|
FROM pg_depend
|
|
WHERE classid = 'pg_operator'::regclass AND
|
|
objid = '===(bool,bool)'::regoperator
|
|
ORDER BY 1;
|
|
|
|
--
|
|
-- Reset and set params
|
|
--
|
|
|
|
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = NONE);
|
|
ALTER OPERATOR === (boolean, boolean) SET (JOIN = NONE);
|
|
|
|
SELECT oprrest, oprjoin FROM pg_operator WHERE oprname = '==='
|
|
AND oprleft = 'boolean'::regtype AND oprright = 'boolean'::regtype;
|
|
|
|
SELECT pg_describe_object(refclassid,refobjid,refobjsubid) as ref, deptype
|
|
FROM pg_depend
|
|
WHERE classid = 'pg_operator'::regclass AND
|
|
objid = '===(bool,bool)'::regoperator
|
|
ORDER BY 1;
|
|
|
|
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = contsel);
|
|
ALTER OPERATOR === (boolean, boolean) SET (JOIN = contjoinsel);
|
|
|
|
SELECT oprrest, oprjoin FROM pg_operator WHERE oprname = '==='
|
|
AND oprleft = 'boolean'::regtype AND oprright = 'boolean'::regtype;
|
|
|
|
SELECT pg_describe_object(refclassid,refobjid,refobjsubid) as ref, deptype
|
|
FROM pg_depend
|
|
WHERE classid = 'pg_operator'::regclass AND
|
|
objid = '===(bool,bool)'::regoperator
|
|
ORDER BY 1;
|
|
|
|
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = NONE, JOIN = NONE);
|
|
|
|
SELECT oprrest, oprjoin FROM pg_operator WHERE oprname = '==='
|
|
AND oprleft = 'boolean'::regtype AND oprright = 'boolean'::regtype;
|
|
|
|
SELECT pg_describe_object(refclassid,refobjid,refobjsubid) as ref, deptype
|
|
FROM pg_depend
|
|
WHERE classid = 'pg_operator'::regclass AND
|
|
objid = '===(bool,bool)'::regoperator
|
|
ORDER BY 1;
|
|
|
|
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = customcontsel, JOIN = contjoinsel);
|
|
|
|
SELECT oprrest, oprjoin FROM pg_operator WHERE oprname = '==='
|
|
AND oprleft = 'boolean'::regtype AND oprright = 'boolean'::regtype;
|
|
|
|
SELECT pg_describe_object(refclassid,refobjid,refobjsubid) as ref, deptype
|
|
FROM pg_depend
|
|
WHERE classid = 'pg_operator'::regclass AND
|
|
objid = '===(bool,bool)'::regoperator
|
|
ORDER BY 1;
|
|
|
|
--
|
|
-- Test invalid options.
|
|
--
|
|
ALTER OPERATOR === (boolean, boolean) SET (COMMUTATOR = ====);
|
|
ALTER OPERATOR === (boolean, boolean) SET (NEGATOR = ====);
|
|
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = non_existent_func);
|
|
ALTER OPERATOR === (boolean, boolean) SET (JOIN = non_existent_func);
|
|
ALTER OPERATOR === (boolean, boolean) SET (COMMUTATOR = !==);
|
|
ALTER OPERATOR === (boolean, boolean) SET (NEGATOR = !==);
|
|
|
|
--
|
|
-- Test permission check. Must be owner to ALTER OPERATOR.
|
|
--
|
|
CREATE USER regress_alter_op_user;
|
|
SET SESSION AUTHORIZATION regress_alter_op_user;
|
|
|
|
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = NONE);
|
|
|
|
-- Clean up
|
|
RESET SESSION AUTHORIZATION;
|
|
DROP USER regress_alter_op_user;
|
|
DROP OPERATOR === (boolean, boolean);
|
|
DROP FUNCTION customcontsel(internal, oid, internal, integer);
|
|
DROP FUNCTION alter_op_test_fn(boolean, boolean);
|