mirror of
https://github.com/postgres/postgres.git
synced 2026-07-09 09:41:00 -04:00
d4a7e1886c
The LWLock used by this test module was defined as a process-local
variable, which was broken under -DEXEC_BACKEND, each backend getting
its own copy of the lock state. The shmem_startup_hook unconditionally
called LWLockRegisterTranche() and LWLockInitialize(), which means that
every backend would allocate a new tranche ID (which is still OK for
this module) but reset the lock's atomic state (which was bad).
This commit moves the LWLock to shared memory, so as it is initialized
only once, similarly to pg_prewarm/autoprewarm.c.
This change is only for REL_16_STABLE, per a report from buildfarm
member gokiburi (the system has been upgraded recently, so perhaps it
began failing due to some ALSR changes?). I have been able to reproduce
the problem on the same host with -DEXEC_BACKEND, and checked that this
commit addresses the issue. In v17 and v18, the test module wastes
tranche IDs, which only impacts the visibility of the locks like in
pg_stat_activity. The use of the SLRU bank locks ensures that the
LWLock state is safe. On HEAD, the logic of the module is safer thanks
to
|
||
|---|---|---|
| .. | ||
| ci | ||
| editors | ||
| ifaddrs | ||
| msvc | ||
| perlcheck | ||
| pg_bsd_indent | ||
| pginclude | ||
| pgindent | ||
| add_commit_links.pl | ||
| ccsym | ||
| check_bison_recursion.pl | ||
| codelines | ||
| copyright.pl | ||
| darwin_sysroot | ||
| find_badmacros | ||
| find_meson | ||
| find_static | ||
| find_typedef | ||
| fix-old-flex-code.pl | ||
| gen_export.pl | ||
| gen_keywordlist.pl | ||
| git-external-diff | ||
| git_changelog | ||
| install_files | ||
| make_ctags | ||
| make_etags | ||
| make_mkid | ||
| mark_pgdllimport.pl | ||
| PerfectHash.pm | ||
| pgflex | ||
| pgtest | ||
| rcgen | ||
| RELEASE_CHANGES | ||
| testint128.c | ||
| testwrap | ||
| valgrind.supp | ||
| version_stamp.pl | ||
| win32tzlist.pl | ||