upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-02-27 20:00:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/include
History
Tom Lane d43a619c60 Fix check_srf_call_placement() to handle VALUES cases correctly. 
INSERT ... VALUES with a single VALUES row is implemented quite differently
from the general VALUES case.  A user-visible implication of that is that
we accept SRFs in the single-row case, but not in the multi-row case.
That's a historical artifact no doubt, but in view of the lack of field
complaints, I'm not excited about fixing it right now.

However, check_srf_call_placement() needs to know about this, first because
it should throw an error in the unsupported case, and second because it
should set p_hasTargetSRFs in the single-row case (because we treat that
like a SELECT tlist).  That's an oversight in commit a4c35ea1c.

To fix, split EXPR_KIND_VALUES into two values.  So far as I can see,
this is the only place where we need to distinguish the two cases at
present; but there might be more later.

Patch by me, per report from Andres Freund.

Discussion: https://postgr.es/m/20170116081548.zg63zltblwimpfgp@alap3.anarazel.de
2017-01-16 15:23:11 -05:00
..
access Fix ALTER TABLE / SET TYPE for irregular inheritance 2017-01-09 19:26:58 -03:00
bootstrap Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
catalog Change representation of statement lists, and add statement location info. 2017-01-14 16:02:35 -05:00
commands Change representation of statement lists, and add statement location info. 2017-01-14 16:02:35 -05:00
common Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
datatype Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
executor Change representation of statement lists, and add statement location info. 2017-01-14 16:02:35 -05:00
fe_utils Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
foreign Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
lib Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
libpq Re-allow SSL passphrase prompt at server start, but not thereafter. 2017-01-04 12:44:03 -05:00
mb Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
nodes Change representation of statement lists, and add statement location info. 2017-01-14 16:02:35 -05:00
optimizer Fix matching of boolean index columns to sort ordering. 2017-01-15 14:09:35 -05:00
parser Fix check_srf_call_placement() to handle VALUES cases correctly. 2017-01-16 15:23:11 -05:00
port Prefer int-wide pg_atomic_flag over char-wide when using gcc intrinsics. 2017-01-04 13:36:55 -05:00
portability Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
postmaster Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
regex Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
replication Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
rewrite Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
snowball Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
storage Update obsolete comments in lwlock.h. 2017-01-04 12:03:40 -05:00
tcop Change representation of statement lists, and add statement location info. 2017-01-14 16:02:35 -05:00
tsearch Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
utils Change representation of statement lists, and add statement location info. 2017-01-14 16:02:35 -05:00
.gitignore Autoconfiscate selection of 64-bit int type for 64-bit large object API. 2012-10-07 21:52:43 -04:00
c.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
fmgr.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
funcapi.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getaddrinfo.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getopt_long.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
Makefile Create src/fe_utils/, and move stuff into there from pg_dump's dumputils. 2016-03-24 15:55:57 -04:00
miscadmin.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_config.h.in Use clock_gettime(), if available, in instr_time measurements. 2017-01-02 13:41:51 -05:00
pg_config.h.win32 Use clock_gettime(), if available, in instr_time measurements. 2017-01-02 13:41:51 -05:00
pg_config_ext.h.in Autoconfiscate selection of 64-bit int type for 64-bit large object API. 2012-10-07 21:52:43 -04:00
pg_config_ext.h.win32 Autoconfiscate selection of 64-bit int type for 64-bit large object API. 2012-10-07 21:52:43 -04:00
pg_config_manual.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_getopt.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_trace.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgstat.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgtar.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgtime.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
port.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
postgres.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
postgres_ext.h Add a nonlocalized version of the severity field to client error messages. 2016-08-26 16:20:17 -04:00
postgres_fe.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
rusagestub.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
windowapi.h Update copyright via script for 2017 2017-01-03 13:48:53 -05:00