postgresql/src/port
Tom Lane 4e95733b08 In the postmaster, rely on the signal infrastructure to block signals.
POSIX sigaction(2) can be told to block a set of signals while a
signal handler executes.  Make use of that instead of manually
blocking and unblocking signals in the postmaster's signal handlers.
This should save a few cycles, but more importantly it prevents
recursive invocation of signal handlers when many signals arrive in
close succession.  (Assuming that the platform's signal infrastructure
is designed to avoid consuming stack space in that case, but this is
demonstrably true at least on Linux.)  The existing code has been seen
to recurse to the point of stack overflow, either in the postmaster
or in a forked-off child.

Back-patch of commit 9abb2bfc0.  At the time, we'd only seen excess
postmaster stack consumption in the buildfarm; but we now have a
user report of it, and that commit has aged enough to have a fair
amount of confidence that it doesn't break anything.

This still doesn't change anything about the way that it works on
Windows.  Perhaps someone else would like to fix that?

Per bug #16673 from David Geier.  Back-patch to 9.6.  Although
the problem exists in principle before that, we've only seen it
actually materialize in connection with heavy use of parallel
workers, so it doesn't seem necessary to do anything in 9.5;
and the relevant code is different there, too.

Discussion: https://postgr.es/m/16673-d278c604f8e34ec0@postgresql.org
Discussion: https://postgr.es/m/14878.1570820201@sss.pgh.pa.us
2020-10-15 12:50:57 -04:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
chklocale.c Be more careful about extracting encoding from locale strings on Windows. 2020-03-30 11:14:58 -04:00
crypt.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
dirent.c Fix error handling of readdir() port implementation on first file lookup 2019-03-04 09:50:06 +09:00
dirmod.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
erand48.c Fix latent problem with pg_jrand48(). 2018-12-28 14:08:35 -05:00
fls.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
fseeko.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getaddrinfo.c Clean up assorted misuses of snprintf()'s result value. 2018-08-15 16:29:32 -04:00
getopt.c Use our own getopt() on OpenBSD. 2019-01-18 15:06:26 -05:00
getopt_long.c Fix our getopt_long's behavior for a command line argument of just "-". 2020-03-23 11:58:01 -04:00
getpeereid.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
getrusage.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
gettimeofday.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
inet_aton.c Initial pgindent run with pg_bsd_indent version 2.0. 2017-06-21 14:39:04 -04:00
inet_net_ntop.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
isinf.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
kill.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
Makefile Replace use of sys_siglist[] with strsignal(). 2020-07-15 22:05:12 -04:00
mkdtemp.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
noblock.c Avoid depending on non-POSIX behavior of fcntl(2). 2017-04-21 15:56:16 -04:00
open.c In pgwin32_open, loop after ERROR_ACCESS_DENIED only if we can't stat. 2019-12-21 17:39:36 -05:00
path.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
pg_crc32c_choose.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pg_crc32c_sb8.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
pg_crc32c_sse42.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
pg_strong_random.c Guard against rare RAND_bytes() failures in pg_strong_random(). 2018-07-20 08:58:37 +01:00
pgcheckdir.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
pgstrcasecmp.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
pgstrsignal.c Replace use of sys_siglist[] with strsignal(). 2020-07-15 22:05:12 -04:00
pqsignal.c In the postmaster, rely on the signal infrastructure to block signals. 2020-10-15 12:50:57 -04:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort.c Get rid of trailing semicolons in C macro definitions. 2020-05-01 17:28:01 -04:00
qsort_arg.c Get rid of trailing semicolons in C macro definitions. 2020-05-01 17:28:01 -04:00
quotes.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
random.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
README Refer to OS X as "macOS", except for the port name which is still "darwin". 2016-09-25 15:40:57 -04:00
rint.c Upgrade src/port/rint.c to be POSIX-compliant. 2015-03-25 15:54:18 -04:00
snprintf.c Set snprintf.c's maximum number of NL arguments to be 31. 2018-10-02 12:41:28 -04:00
sprompt.c Fix simple_prompt() to disable echo on Windows when stdin != terminal. 2018-05-23 19:04:34 -04:00
srandom.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
system.c Remove useless duplicate inclusions of system header files. 2017-02-25 16:12:55 -05:00
tar.c Allow pg_basebackup to stream transaction log in tar mode 2016-10-23 15:23:11 +02:00
thread.c Initial pgindent run with pg_bsd_indent version 2.0. 2017-06-21 14:39:04 -04:00
unsetenv.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright via script for 2017 2017-01-03 13:48:53 -05:00
win32error.c Initial pgindent run with pg_bsd_indent version 2.0. 2017-06-21 14:39:04 -04:00
win32security.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
win32setlocale.c Deal with yet another issue related to "Norwegian (Bokmål)" locale. 2019-10-21 14:18:38 -04:00
win32ver.rc Stamp 10.14. 2020-08-10 17:19:16 -04:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.