mirror of
https://github.com/postgres/postgres.git
synced 2026-03-14 22:53:49 -04:00
2cf8c7aa48
Many of the objects we create during the regression tests are put in the public schema, so that using the same names in different regression tests creates a hazard of test failures if any two such scripts run concurrently. This patch cleans up a bunch of latent hazards of that sort, as well as two live hazards. The current situation in this regard is far worse than it was a year or two back, because practically all of the partitioning-related test cases have reused table names with enthusiasm. I despaired of cleaning up that mess within the five most-affected tests (create_table, alter_table, insert, update, inherit); fortunately those don't run concurrently. Other than partitioning problems, most of the issues boil down to using names like "foo", "bar", "tmp", etc, without thought for the fact that other test scripts might use similar names concurrently. I've made an effort to make all such names more specific. One of the live hazards was that commit7421f4b8caused with.sql to create a table named "test", conflicting with a similarly-named table in alter_table.sql; this was exposed in the buildfarm recently. The other one was that join.sql and transactions.sql both create tables named "foo" and "bar"; but join.sql's uses of those names date back only to December or so. Since commit7421f4b8was back-patched to v10, back-patch a minimal fix for that problem. The rest of this is just future-proofing. Discussion: https://postgr.es/m/4627.1521070268@sss.pgh.pa.us
105 lines
3.1 KiB
PL/PgSQL
105 lines
3.1 KiB
PL/PgSQL
--
|
|
-- SELECT_INTO
|
|
--
|
|
|
|
SELECT *
|
|
INTO TABLE sitmp1
|
|
FROM onek
|
|
WHERE onek.unique1 < 2;
|
|
|
|
DROP TABLE sitmp1;
|
|
|
|
SELECT *
|
|
INTO TABLE sitmp1
|
|
FROM onek2
|
|
WHERE onek2.unique1 < 2;
|
|
|
|
DROP TABLE sitmp1;
|
|
|
|
--
|
|
-- SELECT INTO and INSERT permission, if owner is not allowed to insert.
|
|
--
|
|
CREATE SCHEMA selinto_schema;
|
|
CREATE USER regress_selinto_user;
|
|
ALTER DEFAULT PRIVILEGES FOR ROLE regress_selinto_user
|
|
REVOKE INSERT ON TABLES FROM regress_selinto_user;
|
|
GRANT ALL ON SCHEMA selinto_schema TO public;
|
|
|
|
SET SESSION AUTHORIZATION regress_selinto_user;
|
|
SELECT * INTO TABLE selinto_schema.tmp1
|
|
FROM pg_class WHERE relname like '%a%'; -- Error
|
|
SELECT oid AS clsoid, relname, relnatts + 10 AS x
|
|
INTO selinto_schema.tmp2
|
|
FROM pg_class WHERE relname like '%b%'; -- Error
|
|
CREATE TABLE selinto_schema.tmp3 (a,b,c)
|
|
AS SELECT oid,relname,relacl FROM pg_class
|
|
WHERE relname like '%c%'; -- Error
|
|
RESET SESSION AUTHORIZATION;
|
|
|
|
ALTER DEFAULT PRIVILEGES FOR ROLE regress_selinto_user
|
|
GRANT INSERT ON TABLES TO regress_selinto_user;
|
|
|
|
SET SESSION AUTHORIZATION regress_selinto_user;
|
|
SELECT * INTO TABLE selinto_schema.tmp1
|
|
FROM pg_class WHERE relname like '%a%'; -- OK
|
|
SELECT oid AS clsoid, relname, relnatts + 10 AS x
|
|
INTO selinto_schema.tmp2
|
|
FROM pg_class WHERE relname like '%b%'; -- OK
|
|
CREATE TABLE selinto_schema.tmp3 (a,b,c)
|
|
AS SELECT oid,relname,relacl FROM pg_class
|
|
WHERE relname like '%c%'; -- OK
|
|
RESET SESSION AUTHORIZATION;
|
|
|
|
DROP SCHEMA selinto_schema CASCADE;
|
|
DROP USER regress_selinto_user;
|
|
|
|
-- Tests for WITH NO DATA and column name consistency
|
|
CREATE TABLE ctas_base (i int, j int);
|
|
INSERT INTO ctas_base VALUES (1, 2);
|
|
CREATE TABLE ctas_nodata (ii, jj, kk) AS SELECT i, j FROM ctas_base; -- Error
|
|
CREATE TABLE ctas_nodata (ii, jj, kk) AS SELECT i, j FROM ctas_base WITH NO DATA; -- Error
|
|
CREATE TABLE ctas_nodata (ii, jj) AS SELECT i, j FROM ctas_base; -- OK
|
|
CREATE TABLE ctas_nodata_2 (ii, jj) AS SELECT i, j FROM ctas_base WITH NO DATA; -- OK
|
|
CREATE TABLE ctas_nodata_3 (ii) AS SELECT i, j FROM ctas_base; -- OK
|
|
CREATE TABLE ctas_nodata_4 (ii) AS SELECT i, j FROM ctas_base WITH NO DATA; -- OK
|
|
SELECT * FROM ctas_nodata;
|
|
SELECT * FROM ctas_nodata_2;
|
|
SELECT * FROM ctas_nodata_3;
|
|
SELECT * FROM ctas_nodata_4;
|
|
DROP TABLE ctas_base;
|
|
DROP TABLE ctas_nodata;
|
|
DROP TABLE ctas_nodata_2;
|
|
DROP TABLE ctas_nodata_3;
|
|
DROP TABLE ctas_nodata_4;
|
|
|
|
--
|
|
-- CREATE TABLE AS/SELECT INTO as last command in a SQL function
|
|
-- have been known to cause problems
|
|
--
|
|
CREATE FUNCTION make_table() RETURNS VOID
|
|
AS $$
|
|
CREATE TABLE created_table AS SELECT * FROM int8_tbl;
|
|
$$ LANGUAGE SQL;
|
|
|
|
SELECT make_table();
|
|
|
|
SELECT * FROM created_table;
|
|
|
|
-- Try EXPLAIN ANALYZE SELECT INTO, but hide the output since it won't
|
|
-- be stable.
|
|
DO $$
|
|
BEGIN
|
|
EXECUTE 'EXPLAIN ANALYZE SELECT * INTO TABLE easi FROM int8_tbl';
|
|
END$$;
|
|
|
|
DROP TABLE created_table;
|
|
DROP TABLE easi;
|
|
|
|
--
|
|
-- Disallowed uses of SELECT ... INTO. All should fail
|
|
--
|
|
DECLARE foo CURSOR FOR SELECT 1 INTO b;
|
|
COPY (SELECT 1 INTO frak UNION SELECT 2) TO 'blob';
|
|
SELECT * FROM (SELECT 1 INTO f) bar;
|
|
CREATE VIEW foo AS SELECT 1 INTO b;
|
|
INSERT INTO b SELECT 1 INTO f;
|