mirror of
https://github.com/postgres/postgres.git
synced 2026-04-08 10:38:53 -04:00
Newest versions of gcc+glibc are able to detect cases where code implicitly casts away const by assigning the result of strchr() or a similar function applied to a "const char *" value to a target variable that's just "char *". This of course creates a hazard of not getting a compiler warning about scribbling on a string one was not supposed to, so fixing up such cases is good. This patch fixes a dozen or so places where we were doing that. Most are trivial additions of "const" to the target variable, since no actually-hazardous change was occurring. Thanks to Bertrand Drouvot for finding a couple more spots than I had. This commit back-patches relevant portions of8f1791c61and9f7565c6cinto supported branches. However, there are two places in ecpg (in v18 only) where a proper fix is more complicated than seems appropriate for a back-patch. I opted to silence those two warnings by adding casts. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/1324889.1764886170@sss.pgh.pa.us Discussion: https://postgr.es/m/3988414.1771950285@sss.pgh.pa.us Backpatch-through: 14-18
656 lines
15 KiB
C
656 lines
15 KiB
C
/* src/interfaces/ecpg/preproc/variable.c */
|
|
|
|
#include "postgres_fe.h"
|
|
|
|
#include "preproc_extern.h"
|
|
|
|
static struct variable *allvariables = NULL;
|
|
|
|
struct variable *
|
|
new_variable(const char *name, struct ECPGtype *type, int brace_level)
|
|
{
|
|
struct variable *p = (struct variable *) mm_alloc(sizeof(struct variable));
|
|
|
|
p->name = mm_strdup(name);
|
|
p->type = type;
|
|
p->brace_level = brace_level;
|
|
|
|
p->next = allvariables;
|
|
allvariables = p;
|
|
|
|
return p;
|
|
}
|
|
|
|
static struct variable *
|
|
find_struct_member(const char *name, char *str, struct ECPGstruct_member *members, int brace_level)
|
|
{
|
|
char *next = strpbrk(++str, ".-["),
|
|
*end,
|
|
c = '\0';
|
|
|
|
if (next != NULL)
|
|
{
|
|
c = *next;
|
|
*next = '\0';
|
|
}
|
|
|
|
for (; members; members = members->next)
|
|
{
|
|
if (strcmp(members->name, str) == 0)
|
|
{
|
|
if (next == NULL)
|
|
{
|
|
/* found the end */
|
|
switch (members->type->type)
|
|
{
|
|
case ECPGt_array:
|
|
return new_variable(name, ECPGmake_array_type(ECPGmake_simple_type(members->type->u.element->type, members->type->u.element->size, members->type->u.element->counter), members->type->size), brace_level);
|
|
case ECPGt_struct:
|
|
case ECPGt_union:
|
|
return new_variable(name, ECPGmake_struct_type(members->type->u.members, members->type->type, members->type->type_name, members->type->struct_sizeof), brace_level);
|
|
default:
|
|
return new_variable(name, ECPGmake_simple_type(members->type->type, members->type->size, members->type->counter), brace_level);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
*next = c;
|
|
if (c == '[')
|
|
{
|
|
int count;
|
|
|
|
/*
|
|
* We don't care about what's inside the array brackets so
|
|
* just eat up the character
|
|
*/
|
|
for (count = 1, end = next + 1; count; end++)
|
|
{
|
|
switch (*end)
|
|
{
|
|
case '[':
|
|
count++;
|
|
break;
|
|
case ']':
|
|
count--;
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
else
|
|
end = next;
|
|
|
|
switch (*end)
|
|
{
|
|
case '\0': /* found the end, but this time it has to be
|
|
* an array element */
|
|
if (members->type->type != ECPGt_array)
|
|
mmfatal(PARSE_ERROR, "incorrectly formed variable \"%s\"", name);
|
|
|
|
switch (members->type->u.element->type)
|
|
{
|
|
case ECPGt_array:
|
|
return new_variable(name, ECPGmake_array_type(ECPGmake_simple_type(members->type->u.element->u.element->type, members->type->u.element->u.element->size, members->type->u.element->u.element->counter), members->type->u.element->size), brace_level);
|
|
case ECPGt_struct:
|
|
case ECPGt_union:
|
|
return new_variable(name, ECPGmake_struct_type(members->type->u.element->u.members, members->type->u.element->type, members->type->u.element->type_name, members->type->u.element->struct_sizeof), brace_level);
|
|
default:
|
|
return new_variable(name, ECPGmake_simple_type(members->type->u.element->type, members->type->u.element->size, members->type->u.element->counter), brace_level);
|
|
}
|
|
break;
|
|
case '-':
|
|
if (members->type->type == ECPGt_array)
|
|
return find_struct_member(name, ++end, members->type->u.element->u.members, brace_level);
|
|
else
|
|
return find_struct_member(name, ++end, members->type->u.members, brace_level);
|
|
break;
|
|
case '.':
|
|
if (members->type->type == ECPGt_array)
|
|
return find_struct_member(name, end, members->type->u.element->u.members, brace_level);
|
|
else
|
|
return find_struct_member(name, end, members->type->u.members, brace_level);
|
|
break;
|
|
default:
|
|
mmfatal(PARSE_ERROR, "incorrectly formed variable \"%s\"", name);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static struct variable *
|
|
find_struct(const char *name, char *next, char *end)
|
|
{
|
|
struct variable *p;
|
|
char c = *next;
|
|
|
|
/* first get the mother structure entry */
|
|
*next = '\0';
|
|
p = find_variable(name);
|
|
|
|
if (c == '-')
|
|
{
|
|
if (p->type->type != ECPGt_array)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is not a pointer", name);
|
|
|
|
if (p->type->u.element->type != ECPGt_struct && p->type->u.element->type != ECPGt_union)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is not a pointer to a structure or a union", name);
|
|
|
|
/* restore the name, we will need it later */
|
|
*next = c;
|
|
|
|
return find_struct_member(name, ++end, p->type->u.element->u.members, p->brace_level);
|
|
}
|
|
else
|
|
{
|
|
if (next == end)
|
|
{
|
|
if (p->type->type != ECPGt_struct && p->type->type != ECPGt_union)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is neither a structure nor a union", name);
|
|
|
|
/* restore the name, we will need it later */
|
|
*next = c;
|
|
|
|
return find_struct_member(name, end, p->type->u.members, p->brace_level);
|
|
}
|
|
else
|
|
{
|
|
if (p->type->type != ECPGt_array)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is not an array", name);
|
|
|
|
if (p->type->u.element->type != ECPGt_struct && p->type->u.element->type != ECPGt_union)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is not a pointer to a structure or a union", name);
|
|
|
|
/* restore the name, we will need it later */
|
|
*next = c;
|
|
|
|
return find_struct_member(name, end, p->type->u.element->u.members, p->brace_level);
|
|
}
|
|
}
|
|
}
|
|
|
|
static struct variable *
|
|
find_simple(const char *name)
|
|
{
|
|
struct variable *p;
|
|
|
|
for (p = allvariables; p; p = p->next)
|
|
{
|
|
if (strcmp(p->name, name) == 0)
|
|
return p;
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* Note that this function will end the program in case of an unknown */
|
|
/* variable */
|
|
struct variable *
|
|
find_variable(const char *name)
|
|
{
|
|
char *next,
|
|
*end;
|
|
struct variable *p;
|
|
int count;
|
|
|
|
next = (char *) strpbrk(name, ".[-");
|
|
if (next)
|
|
{
|
|
if (*next == '[')
|
|
{
|
|
/*
|
|
* We don't care about what's inside the array brackets so just
|
|
* eat up the characters
|
|
*/
|
|
for (count = 1, end = next + 1; count; end++)
|
|
{
|
|
switch (*end)
|
|
{
|
|
case '[':
|
|
count++;
|
|
break;
|
|
case ']':
|
|
count--;
|
|
break;
|
|
case '\0':
|
|
mmfatal(PARSE_ERROR, "unmatched bracket in variable \"%s\"", name);
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
if (*end == '.')
|
|
p = find_struct(name, next, end);
|
|
else
|
|
{
|
|
char c = *next;
|
|
|
|
*next = '\0';
|
|
p = find_simple(name);
|
|
if (p == NULL)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is not declared", name);
|
|
if (p->type->type != ECPGt_array)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is not a pointer", name);
|
|
*next = c;
|
|
switch (p->type->u.element->type)
|
|
{
|
|
case ECPGt_array:
|
|
return new_variable(name, ECPGmake_array_type(ECPGmake_simple_type(p->type->u.element->u.element->type, p->type->u.element->u.element->size, p->type->u.element->u.element->counter), p->type->u.element->size), p->brace_level);
|
|
case ECPGt_struct:
|
|
case ECPGt_union:
|
|
return new_variable(name, ECPGmake_struct_type(p->type->u.element->u.members, p->type->u.element->type, p->type->u.element->type_name, p->type->u.element->struct_sizeof), p->brace_level);
|
|
default:
|
|
return new_variable(name, ECPGmake_simple_type(p->type->u.element->type, p->type->u.element->size, p->type->u.element->counter), p->brace_level);
|
|
}
|
|
}
|
|
}
|
|
else
|
|
p = find_struct(name, next, next);
|
|
}
|
|
else
|
|
p = find_simple(name);
|
|
|
|
if (p == NULL)
|
|
mmfatal(PARSE_ERROR, "variable \"%s\" is not declared", name);
|
|
|
|
return p;
|
|
}
|
|
|
|
void
|
|
remove_typedefs(int brace_level)
|
|
{
|
|
struct typedefs *p,
|
|
*prev,
|
|
*next;
|
|
|
|
for (p = types, prev = NULL; p; p = next)
|
|
{
|
|
next = p->next;
|
|
if (p->brace_level >= brace_level)
|
|
{
|
|
/* remove it */
|
|
if (prev)
|
|
prev->next = next;
|
|
else
|
|
types = next;
|
|
|
|
if (p->type->type_enum == ECPGt_struct || p->type->type_enum == ECPGt_union)
|
|
ECPGfree_struct_member(p->struct_member_list);
|
|
free(p->type->type_storage);
|
|
free(p->type->type_str);
|
|
free(p->type->type_dimension);
|
|
free(p->type->type_index);
|
|
free(p->type->type_sizeof);
|
|
free(p->type);
|
|
free(p->name);
|
|
free(p);
|
|
}
|
|
else
|
|
prev = p;
|
|
}
|
|
}
|
|
|
|
void
|
|
remove_variables(int brace_level)
|
|
{
|
|
struct variable *p,
|
|
*prev,
|
|
*next;
|
|
|
|
for (p = allvariables, prev = NULL; p; p = next)
|
|
{
|
|
next = p->next;
|
|
if (p->brace_level >= brace_level)
|
|
{
|
|
/* remove it, but first remove any references from cursors */
|
|
struct cursor *ptr;
|
|
|
|
for (ptr = cur; ptr != NULL; ptr = ptr->next)
|
|
{
|
|
struct arguments *varptr,
|
|
*prevvar,
|
|
*nextvar;
|
|
|
|
for (varptr = ptr->argsinsert, prevvar = NULL;
|
|
varptr != NULL; varptr = nextvar)
|
|
{
|
|
nextvar = varptr->next;
|
|
if (p == varptr->variable)
|
|
{
|
|
/* remove from list */
|
|
if (prevvar)
|
|
prevvar->next = nextvar;
|
|
else
|
|
ptr->argsinsert = nextvar;
|
|
free(varptr);
|
|
}
|
|
else
|
|
prevvar = varptr;
|
|
}
|
|
for (varptr = ptr->argsresult, prevvar = NULL;
|
|
varptr != NULL; varptr = nextvar)
|
|
{
|
|
nextvar = varptr->next;
|
|
if (p == varptr->variable)
|
|
{
|
|
/* remove from list */
|
|
if (prevvar)
|
|
prevvar->next = nextvar;
|
|
else
|
|
ptr->argsresult = nextvar;
|
|
free(varptr);
|
|
}
|
|
else
|
|
prevvar = varptr;
|
|
}
|
|
}
|
|
|
|
/* remove it */
|
|
if (prev)
|
|
prev->next = next;
|
|
else
|
|
allvariables = next;
|
|
|
|
ECPGfree_type(p->type);
|
|
free(p->name);
|
|
free(p);
|
|
}
|
|
else
|
|
prev = p;
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
* Here are the variables that need to be handled on every request.
|
|
* These are of two kinds: input and output.
|
|
* I will make two lists for them.
|
|
*/
|
|
|
|
struct arguments *argsinsert = NULL;
|
|
struct arguments *argsresult = NULL;
|
|
|
|
void
|
|
reset_variables(void)
|
|
{
|
|
struct arguments *p,
|
|
*next;
|
|
|
|
for (p = argsinsert; p; p = next)
|
|
{
|
|
next = p->next;
|
|
free(p);
|
|
}
|
|
argsinsert = NULL;
|
|
for (p = argsresult; p; p = next)
|
|
{
|
|
next = p->next;
|
|
free(p);
|
|
}
|
|
argsresult = NULL;
|
|
}
|
|
|
|
/* Insert a new variable into our request list.
|
|
* Note: The list is dumped from the end,
|
|
* so we have to add new entries at the beginning */
|
|
void
|
|
add_variable_to_head(struct arguments **list, struct variable *var, struct variable *ind)
|
|
{
|
|
struct arguments *p = (struct arguments *) mm_alloc(sizeof(struct arguments));
|
|
|
|
p->variable = var;
|
|
p->indicator = ind;
|
|
p->next = *list;
|
|
*list = p;
|
|
}
|
|
|
|
/* Append a new variable to our request list. */
|
|
void
|
|
add_variable_to_tail(struct arguments **list, struct variable *var, struct variable *ind)
|
|
{
|
|
struct arguments *p,
|
|
*new = (struct arguments *) mm_alloc(sizeof(struct arguments));
|
|
|
|
for (p = *list; p && p->next; p = p->next);
|
|
|
|
new->variable = var;
|
|
new->indicator = ind;
|
|
new->next = NULL;
|
|
|
|
if (p)
|
|
p->next = new;
|
|
else
|
|
*list = new;
|
|
}
|
|
|
|
void
|
|
remove_variable_from_list(struct arguments **list, struct variable *var)
|
|
{
|
|
struct arguments *p,
|
|
*prev = NULL;
|
|
bool found = false;
|
|
|
|
for (p = *list; p; p = p->next)
|
|
{
|
|
if (p->variable == var)
|
|
{
|
|
found = true;
|
|
break;
|
|
}
|
|
prev = p;
|
|
}
|
|
if (found)
|
|
{
|
|
if (prev)
|
|
prev->next = p->next;
|
|
else
|
|
*list = p->next;
|
|
free(p);
|
|
}
|
|
}
|
|
|
|
/* Dump out a list of all the variable on this list.
|
|
This is a recursive function that works from the end of the list and
|
|
deletes the list as we go on.
|
|
*/
|
|
void
|
|
dump_variables(struct arguments *list, int mode)
|
|
{
|
|
char *str_zero;
|
|
|
|
if (list == NULL)
|
|
return;
|
|
|
|
str_zero = mm_strdup("0");
|
|
|
|
/*
|
|
* The list is build up from the beginning so lets first dump the end of
|
|
* the list:
|
|
*/
|
|
|
|
dump_variables(list->next, mode);
|
|
|
|
/* Then the current element and its indicator */
|
|
ECPGdump_a_type(base_yyout, list->variable->name, list->variable->type, list->variable->brace_level,
|
|
list->indicator->name, list->indicator->type, list->indicator->brace_level,
|
|
NULL, NULL, str_zero, NULL, NULL);
|
|
|
|
/* Then release the list element. */
|
|
if (mode != 0)
|
|
free(list);
|
|
|
|
free(str_zero);
|
|
}
|
|
|
|
void
|
|
check_indicator(struct ECPGtype *var)
|
|
{
|
|
/* make sure this is a valid indicator variable */
|
|
switch (var->type)
|
|
{
|
|
struct ECPGstruct_member *p;
|
|
|
|
case ECPGt_short:
|
|
case ECPGt_int:
|
|
case ECPGt_long:
|
|
case ECPGt_long_long:
|
|
case ECPGt_unsigned_short:
|
|
case ECPGt_unsigned_int:
|
|
case ECPGt_unsigned_long:
|
|
case ECPGt_unsigned_long_long:
|
|
break;
|
|
|
|
case ECPGt_struct:
|
|
case ECPGt_union:
|
|
for (p = var->u.members; p; p = p->next)
|
|
check_indicator(p->type);
|
|
break;
|
|
|
|
case ECPGt_array:
|
|
check_indicator(var->u.element);
|
|
break;
|
|
default:
|
|
mmerror(PARSE_ERROR, ET_ERROR, "indicator variable must have an integer type");
|
|
break;
|
|
}
|
|
}
|
|
|
|
struct typedefs *
|
|
get_typedef(const char *name, bool noerror)
|
|
{
|
|
struct typedefs *this;
|
|
|
|
for (this = types; this != NULL; this = this->next)
|
|
{
|
|
if (strcmp(this->name, name) == 0)
|
|
return this;
|
|
}
|
|
|
|
if (!noerror)
|
|
mmfatal(PARSE_ERROR, "unrecognized data type name \"%s\"", name);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
void
|
|
adjust_array(enum ECPGttype type_enum,
|
|
const char **dimension, const char **length,
|
|
const char *type_dimension, const char *type_index,
|
|
int pointer_len, bool type_definition)
|
|
{
|
|
if (atoi(type_index) >= 0)
|
|
{
|
|
if (atoi(*length) >= 0)
|
|
mmfatal(PARSE_ERROR, "multidimensional arrays are not supported");
|
|
|
|
*length = type_index;
|
|
}
|
|
|
|
if (atoi(type_dimension) >= 0)
|
|
{
|
|
if (atoi(*dimension) >= 0 && atoi(*length) >= 0)
|
|
mmfatal(PARSE_ERROR, "multidimensional arrays are not supported");
|
|
|
|
if (atoi(*dimension) >= 0)
|
|
*length = *dimension;
|
|
|
|
*dimension = type_dimension;
|
|
}
|
|
|
|
if (pointer_len > 2)
|
|
mmfatal(PARSE_ERROR, ngettext("multilevel pointers (more than 2 levels) are not supported; found %d level",
|
|
"multilevel pointers (more than 2 levels) are not supported; found %d levels", pointer_len),
|
|
pointer_len);
|
|
|
|
if (pointer_len > 1 && type_enum != ECPGt_char && type_enum != ECPGt_unsigned_char && type_enum != ECPGt_string)
|
|
mmfatal(PARSE_ERROR, "pointer to pointer is not supported for this data type");
|
|
|
|
if (pointer_len > 1 && (atoi(*length) >= 0 || atoi(*dimension) >= 0))
|
|
mmfatal(PARSE_ERROR, "multidimensional arrays are not supported");
|
|
|
|
if (atoi(*length) >= 0 && atoi(*dimension) >= 0 && pointer_len)
|
|
mmfatal(PARSE_ERROR, "multidimensional arrays are not supported");
|
|
|
|
switch (type_enum)
|
|
{
|
|
case ECPGt_struct:
|
|
case ECPGt_union:
|
|
/* pointer has to get dimension 0 */
|
|
if (pointer_len)
|
|
{
|
|
*length = *dimension;
|
|
*dimension = "0";
|
|
}
|
|
|
|
if (atoi(*length) >= 0)
|
|
mmfatal(PARSE_ERROR, "multidimensional arrays for structures are not supported");
|
|
|
|
break;
|
|
case ECPGt_varchar:
|
|
case ECPGt_bytea:
|
|
/* pointer has to get dimension 0 */
|
|
if (pointer_len)
|
|
*dimension = "0";
|
|
|
|
/* one index is the string length */
|
|
if (atoi(*length) < 0)
|
|
{
|
|
*length = *dimension;
|
|
*dimension = "-1";
|
|
}
|
|
|
|
break;
|
|
case ECPGt_char:
|
|
case ECPGt_unsigned_char:
|
|
case ECPGt_string:
|
|
/* char ** */
|
|
if (pointer_len == 2)
|
|
{
|
|
*length = *dimension = "0";
|
|
break;
|
|
}
|
|
|
|
/* pointer has to get length 0 */
|
|
if (pointer_len == 1)
|
|
*length = "0";
|
|
|
|
/* one index is the string length */
|
|
if (atoi(*length) < 0)
|
|
{
|
|
/*
|
|
* make sure we return length = -1 for arrays without given
|
|
* bounds
|
|
*/
|
|
if (atoi(*dimension) < 0 && !type_definition)
|
|
|
|
/*
|
|
* do not change this for typedefs since it will be
|
|
* changed later on when the variable is defined
|
|
*/
|
|
*length = "1";
|
|
else if (strcmp(*dimension, "0") == 0)
|
|
*length = "-1";
|
|
else
|
|
*length = *dimension;
|
|
|
|
*dimension = "-1";
|
|
}
|
|
break;
|
|
default:
|
|
/* a pointer has dimension = 0 */
|
|
if (pointer_len)
|
|
{
|
|
*length = *dimension;
|
|
*dimension = "0";
|
|
}
|
|
|
|
if (atoi(*length) >= 0)
|
|
mmfatal(PARSE_ERROR, "multidimensional arrays for simple data types are not supported");
|
|
|
|
break;
|
|
}
|
|
}
|