Tom Lane ecb533af62 Further fix dumping of views that contain just VALUES(...). ... It turns out that commit e9f1c01b7 missed a case: we must print a VALUES clause in long format if get_query_def is given a resultDesc that would require the query's output column name(s) to be different from what the bare VALUES clause would produce. This applies in case an ALTER ... RENAME COLUMN has been done to a view that formerly could be printed in simple format, as shown in the added regression test case. It also explains bug #16119 from Dmitry Telpt, because it turns out that (unlike CREATE VIEW) CREATE MATERIALIZED VIEW fails to apply any column aliases it's given to the stored ON SELECT rule. So to get them to be printed, we have to account for the resultDesc renaming. It might be worth changing the matview code so that it creates the ON SELECT rule with the correct aliases; but we'd still need these messy checks in get_simple_values_rte to handle the case of a subsequent column rename, so any such change would be just neatnik-ism not a bug fix. Like the previous patch, back-patch to all supported branches. Discussion: https://postgr.es/m/16119-e64823f30a45a754@postgresql.org		2019-11-16 20:00:20 -05:00
..
backend	Further fix dumping of views that contain just VALUES(...).	2019-11-16 20:00:20 -05:00
bin	Handle arrays and ranges in pg_upgrade's test for non-upgradable types.	2019-11-13 11:35:37 -05:00
common	Fix portability failure introduced in commits d2b0b60e7 et al.	2018-12-26 15:30:35 -05:00
include	Stamp 9.5.20.	2019-11-11 17:11:27 -05:00
interfaces	Stamp 9.5.20.	2019-11-11 17:11:27 -05:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
pl	Translation updates	2019-11-11 10:23:30 +01:00
port	Stamp 9.5.20.	2019-11-11 17:11:27 -05:00
template	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
test	Further fix dumping of views that contain just VALUES(...).	2019-11-16 20:00:20 -05:00
timezone	Update time zone data files to tzdata release 2019c.	2019-09-20 19:54:29 -04:00
tools	Handle spaces in OpenSSL install location for MSVC	2019-10-04 15:38:48 -04:00
tutorial	Remove no-longer-required function declarations.	2015-05-24 12:20:23 -04:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
bcc32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Install TAP test infrastructure so it's available for extension testing.	2016-09-23 15:50:00 -04:00
Makefile.global.in	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00
win32.mak	Autoconfiscate selection of 64-bit int type for 64-bit large object API.	2012-10-07 21:52:43 -04:00