Tom Lane df8020b329 Teach libpq to handle arbitrary-length lines in .pgpass files. ... Historically there's been a hard-wired assumption here that no line of a .pgpass file could be as long as NAMEDATALEN*5 bytes. That's a bit shaky to start off with, because (a) there's no reason to suppose that host names fit in NAMEDATALEN, and (b) this figure fails to allow for backslash escape characters. However, it fails completely if someone wants to use a very long password, and we're now hearing reports of people wanting to use "security tokens" that can run up to several hundred bytes. Another angle is that the file is specified to allow comment lines, but there's no reason to assume that long comment lines aren't possible. Rather than guessing at what might be a more suitable limit, let's replace the fixed-size buffer with an expansible PQExpBuffer. That adds one malloc/free cycle to the typical use-case, but that's surely pretty cheap relative to the I/O this code has to do. Also, add TAP test cases to exercise this code, because there was no test coverage before. This reverts most of commit 2eb3bc588, as there's no longer a need for a warning message about overlength .pgpass lines. (I kept the explicit check for comment lines, though.) In HEAD and v13, this also fixes an oversight in 74a308cf5: there's not much point in explicit_bzero'ing the line buffer if we only do so in two of the three exit paths. Back-patch to all supported branches, except that the test case only goes back to v10 where src/test/authentication/ was added. Discussion: https://postgr.es/m/4187382.1598909041@sss.pgh.pa.us		2020-09-01 13:14:44 -04:00
..
backend	Fix code for re-finding scan position in a multicolumn GIN index.	2020-08-27 17:36:13 -04:00
bin	Translation updates	2020-08-10 15:27:40 +02:00
common	Replace use of sys_siglist[] with strsignal().	2020-07-15 22:05:12 -04:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	C comment: remove mention of use of t_hoff WAL structure member	2020-08-31 17:51:31 -04:00
interfaces	Teach libpq to handle arbitrary-length lines in .pgpass files.	2020-09-01 13:14:44 -04:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
pl	Translation updates	2020-08-10 15:27:40 +02:00
port	Stamp 11.9.	2020-08-10 17:17:40 -04:00
template	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
test	Teach libpq to handle arbitrary-length lines in .pgpass files.	2020-09-01 13:14:44 -04:00
timezone	Ensure that distributed timezone abbreviation files are plain ASCII.	2020-07-17 11:04:36 -04:00
tools	Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.	2020-06-08 20:02:56 -07:00
tutorial	Update copyright for 2018	2018-01-02 23:30:12 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00