Tom Lane e21856fd65 Replace RelationOpenSmgr() with RelationGetSmgr(). ... This is a back-patch of the v15-era commit f10f0ae42 into older supported branches. The idea is to design out bugs in which an ill-timed relcache flush clears rel->rd_smgr partway through some code sequence that wasn't expecting that. We had another report today of a corner case that reliably crashes v14 under debug_discard_caches (nee CLOBBER_CACHE_ALWAYS), and therefore would crash once in a blue moon in the field. We're unlikely to get rid of all such code paths unless we adopt the more rigorous coding rules instituted by f10f0ae42. Therefore, even though this is a bit invasive, it's time to back-patch. Some comfort can be taken in the fact that f10f0ae42 has been in v15 for 16 months without problems. I left the RelationOpenSmgr macro present in the back branches, even though no core code should use it anymore, in order to not break third-party extensions in minor releases. Such extensions might opt to start using RelationGetSmgr instead, to reduce their code differential between v15 and earlier branches. This carries a hazard of failing to compile against headers from existing minor releases. However, once compiled the extension should work fine even with such releases, because RelationGetSmgr is a "static inline" function so it creates no link-time dependency. So depending on distribution practices, that might be an OK tradeoff. Per report from Spyridon Dimitrios Agathos. Original patch by Amul Sul. Discussion: https://postgr.es/m/CAFM5RaqdgyusQvmWkyPYaWMwoK5gigdtW-7HcgHgOeAw7mqJ_Q@mail.gmail.com Discussion: https://postgr.es/m/CANiYTQsU7yMFpQYnv=BrcRVqK_3U3mtAzAsJCaqtzsDHfsUbdQ@mail.gmail.com		2022-11-17 16:54:31 -05:00
..
backend	Replace RelationOpenSmgr() with RelationGetSmgr().	2022-11-17 16:54:31 -05:00
bin	Translation updates	2022-11-07 13:55:08 +01:00
common	Inhibit mingw CRT's auto-globbing of command line arguments	2022-04-25 15:50:07 -04:00
fe_utils	Clean up assorted failures under clang's -fsanitize=undefined checks.	2022-03-03 18:13:24 -05:00
include	Replace RelationOpenSmgr() with RelationGetSmgr().	2022-11-17 16:54:31 -05:00
interfaces	Stamp 12.13.	2022-11-07 16:47:13 -05:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:35 -04:00
pl	Translation updates	2022-11-07 13:55:08 +01:00
port	Re-allow building on Microsoft Visual Studio 2013.	2022-11-10 10:23:49 -05:00
template	On NetBSD, force dynamic symbol resolution at postmaster start.	2022-08-30 17:29:13 -04:00
test	Account for IPC::Run::result() Windows behavior change.	2022-11-17 07:38:28 -08:00
timezone	Update time zone data files to tzdata release 2022f.	2022-11-01 17:09:09 -04:00
tools	Improve setup of environment values for commands in MSVC's vcregress.pl	2022-05-11 10:22:37 +09:00
tutorial	tutorial: land height is "elevation", not "altitude"	2021-03-10 20:25:18 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Fix prove_installcheck to use correct paths when used with PGXS	2021-07-01 08:47:04 -04:00
Makefile.shlib	Fix pkg-config files for static linking	2021-09-06 09:43:18 +02:00
nls-global.mk	NLS: Fix backend gettext triggers	2019-09-23 09:05:50 +02:00