Tom Lane e21856fd65 Replace RelationOpenSmgr() with RelationGetSmgr(). ... This is a back-patch of the v15-era commit f10f0ae42 into older supported branches. The idea is to design out bugs in which an ill-timed relcache flush clears rel->rd_smgr partway through some code sequence that wasn't expecting that. We had another report today of a corner case that reliably crashes v14 under debug_discard_caches (nee CLOBBER_CACHE_ALWAYS), and therefore would crash once in a blue moon in the field. We're unlikely to get rid of all such code paths unless we adopt the more rigorous coding rules instituted by f10f0ae42. Therefore, even though this is a bit invasive, it's time to back-patch. Some comfort can be taken in the fact that f10f0ae42 has been in v15 for 16 months without problems. I left the RelationOpenSmgr macro present in the back branches, even though no core code should use it anymore, in order to not break third-party extensions in minor releases. Such extensions might opt to start using RelationGetSmgr instead, to reduce their code differential between v15 and earlier branches. This carries a hazard of failing to compile against headers from existing minor releases. However, once compiled the extension should work fine even with such releases, because RelationGetSmgr is a "static inline" function so it creates no link-time dependency. So depending on distribution practices, that might be an OK tradeoff. Per report from Spyridon Dimitrios Agathos. Original patch by Amul Sul. Discussion: https://postgr.es/m/CAFM5RaqdgyusQvmWkyPYaWMwoK5gigdtW-7HcgHgOeAw7mqJ_Q@mail.gmail.com Discussion: https://postgr.es/m/CANiYTQsU7yMFpQYnv=BrcRVqK_3U3mtAzAsJCaqtzsDHfsUbdQ@mail.gmail.com		2022-11-17 16:54:31 -05:00
..
expected	Disable vacuum page skipping in selected test cases.	2021-01-20 11:49:29 -05:00
sql	Disable vacuum page skipping in selected test cases.	2021-01-20 11:49:29 -05:00
.gitignore	Add relkind checks to certain contrib modules	2017-03-09 16:34:25 -05:00
Makefile	Default monitoring roles	2017-03-30 14:18:53 -04:00
pg_visibility--1.0--1.1.sql	pg_visibility: Add pg_truncate_visibility_map function.	2016-06-17 17:37:30 -04:00
pg_visibility--1.1--1.2.sql	Default monitoring roles	2017-03-30 14:18:53 -04:00
pg_visibility--1.1.sql	pg_visibility: Add pg_truncate_visibility_map function.	2016-06-17 17:37:30 -04:00
pg_visibility.c	Replace RelationOpenSmgr() with RelationGetSmgr().	2022-11-17 16:54:31 -05:00
pg_visibility.control	Default monitoring roles	2017-03-30 14:18:53 -04:00