mirror of
https://github.com/postgres/postgres.git
synced 2026-02-23 09:52:14 -05:00
b7103bbe34
This coding technique is unsafe, since we'd be accessing off the end of the tuple if the field is null. SIGSEGV is pretty improbable, but perhaps not impossible. Also, returning garbage for the LSN doesn't seem like a great idea, even if callers aren't looking at it today. Also update docs to point out explicitly that pg_subscription.subslotname and pg_subscription_rel.srsublsn can be null. Perhaps we should mark these two fields BKI_FORCE_NULL, so that they'd be correctly labeled in databases that are initdb'd in the future. But we can't force that for existing databases, and on balance it's not too clear that having a mix of different catalog contents in the field would be wise. Apply to v10 (where this code came in) through v12. Already fixed in v13 and HEAD. Discussion: https://postgr.es/m/732838.1595278439@sss.pgh.pa.us
90 lines
2.9 KiB
C
90 lines
2.9 KiB
C
/* -------------------------------------------------------------------------
|
|
*
|
|
* pg_subscription_rel.h
|
|
* definition of the system catalog containing the state for each
|
|
* replicated table in each subscription (pg_subscription_rel)
|
|
*
|
|
* Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/catalog/pg_subscription_rel.h
|
|
*
|
|
* NOTES
|
|
* The Catalog.pm module reads this file and derives schema
|
|
* information.
|
|
*
|
|
* -------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PG_SUBSCRIPTION_REL_H
|
|
#define PG_SUBSCRIPTION_REL_H
|
|
|
|
#include "catalog/genbki.h"
|
|
#include "catalog/pg_subscription_rel_d.h"
|
|
|
|
#include "access/xlogdefs.h"
|
|
#include "nodes/pg_list.h"
|
|
|
|
/* ----------------
|
|
* pg_subscription_rel definition. cpp turns this into
|
|
* typedef struct FormData_pg_subscription_rel
|
|
* ----------------
|
|
*/
|
|
CATALOG(pg_subscription_rel,6102,SubscriptionRelRelationId)
|
|
{
|
|
Oid srsubid; /* Oid of subscription */
|
|
Oid srrelid; /* Oid of relation */
|
|
char srsubstate; /* state of the relation in subscription */
|
|
|
|
/*
|
|
* Although srsublsn is a fixed-width type, it is allowed to be NULL, so
|
|
* we prevent direct C code access to it just as for a varlena field.
|
|
*/
|
|
#ifdef CATALOG_VARLEN /* variable-length fields start here */
|
|
|
|
XLogRecPtr srsublsn; /* remote LSN of the state change used for
|
|
* synchronization coordination, or NULL if
|
|
* not valid */
|
|
#endif
|
|
} FormData_pg_subscription_rel;
|
|
|
|
typedef FormData_pg_subscription_rel *Form_pg_subscription_rel;
|
|
|
|
#ifdef EXPOSE_TO_CLIENT_CODE
|
|
|
|
/* ----------------
|
|
* substate constants
|
|
* ----------------
|
|
*/
|
|
#define SUBREL_STATE_INIT 'i' /* initializing (sublsn NULL) */
|
|
#define SUBREL_STATE_DATASYNC 'd' /* data is being synchronized (sublsn
|
|
* NULL) */
|
|
#define SUBREL_STATE_SYNCDONE 's' /* synchronization finished in front of
|
|
* apply (sublsn set) */
|
|
#define SUBREL_STATE_READY 'r' /* ready (sublsn set) */
|
|
|
|
/* These are never stored in the catalog, we only use them for IPC. */
|
|
#define SUBREL_STATE_UNKNOWN '\0' /* unknown state */
|
|
#define SUBREL_STATE_SYNCWAIT 'w' /* waiting for sync */
|
|
#define SUBREL_STATE_CATCHUP 'c' /* catching up with apply */
|
|
|
|
#endif /* EXPOSE_TO_CLIENT_CODE */
|
|
|
|
typedef struct SubscriptionRelState
|
|
{
|
|
Oid relid;
|
|
XLogRecPtr lsn;
|
|
char state;
|
|
} SubscriptionRelState;
|
|
|
|
extern void AddSubscriptionRelState(Oid subid, Oid relid, char state,
|
|
XLogRecPtr sublsn);
|
|
extern void UpdateSubscriptionRelState(Oid subid, Oid relid, char state,
|
|
XLogRecPtr sublsn);
|
|
extern char GetSubscriptionRelState(Oid subid, Oid relid,
|
|
XLogRecPtr *sublsn, bool missing_ok);
|
|
extern void RemoveSubscriptionRel(Oid subid, Oid relid);
|
|
|
|
extern List *GetSubscriptionRelations(Oid subid);
|
|
extern List *GetSubscriptionNotReadyRelations(Oid subid);
|
|
|
|
#endif /* PG_SUBSCRIPTION_REL_H */
|