postgresql/src/test
Tom Lane 9d15b8b36a Fix crash when columns have been added to the end of a view.
expandRTE() supposed that an RTE_SUBQUERY subquery must have exactly
as many non-junk tlist items as the RTE has column aliases for it.
This was true at the time the code was written, and is still true so
far as parse analysis is concerned --- but when the function is used
during planning, the subquery might have appeared through insertion
of a view that now has more columns than it did when the outer query
was parsed.  This results in a core dump if, for instance, we have
to expand a whole-row Var that references the subquery.

To avoid crashing, we can either stop expanding the RTE when we run
out of aliases, or invent new aliases for the added columns.  While
the latter might be more useful, the former is consistent with what
expandRTE() does for composite-returning functions in the RTE_FUNCTION
case, so it seems like we'd better do it that way.

Per bug #14876 from Samuel Horwitz.  This has been busted since commit
ff1ea2173 allowed views to acquire more columns, so back-patch to all
supported branches.

Discussion: https://postgr.es/m/20171026184035.1471.82810@wrigleys.postgresql.org
2017-10-27 17:10:21 -04:00
..
examples Include <sys/select.h> where needed 2016-09-27 01:05:21 -03:00
isolation Fix freezing of a dead HOT-updated tuple 2017-09-28 16:44:01 +02:00
locale Run newly-configured perltidy script on Perl files. 2012-07-04 21:47:49 -04:00
mb Lots of doc corrections. 2012-04-23 22:43:09 -04:00
performance Run newly-configured perltidy script on Perl files. 2012-07-04 21:47:49 -04:00
regress Fix crash when columns have been added to the end of a view. 2017-10-27 17:10:21 -04:00
thread Update copyrights for 2013 2013-01-01 17:15:01 -05:00
Makefile Add isolation test to check-world and installcheck-world 2012-03-05 20:19:20 +02:00