mirror of
https://github.com/postgres/postgres.git
synced 2026-03-22 10:30:21 -04:00
ecae097252
Because we assume that int64 and double have the same alignment requirement, AIX's default behavior that alignof(double) = 4 while alignof(int64) = 8 is a headache. There are two issues: 1. We align both int8 and float8 tuple columns per ALIGNOF_DOUBLE, which is an ancient choice that can't be undone without breaking pg_upgrade and creating some subtle SQL-level compatibility issues too. However, the cost of that is just some marginal inefficiency in fetching int8 values, which can't be too awful if the platform architects were willing to pay the same costs for fetching float8s. So our decision is to leave that alone. This patch makes our alignment choices the same as they were pre-v17, namely that ALIGNOF_DOUBLE and ALIGNOF_INT64_T are whatever the compiler prefers and then MAXIMUM_ALIGNOF is the larger of the two. (On all supported platforms other than AIX, all three values will be the same.) 2. We need to overlay C structs onto catalog tuples, and int8 fields in those struct declarations may not be aligned to match this rule. In the old branches we had some annoying rules about ordering catalog columns to avoid alignment problems, but nobody wants to resurrect those. However, there's a better answer: make the compiler construe those struct declarations the way we need it to by using the pack(N) pragma. This requires no manual effort to maintain going forward; we only have to insert the pragma into all the catalog *.h files. (As the catalogs stand at this writing, nothing actually changes because we've not moved any affected columns since v16; hence no catversion bump is required. The point of this is to not have to worry about the issue going forward.) We did not have this option when the AIX port was first made. This patch depends on the C99 feature _Pragma(), as well as the pack(N) pragma which dates to somewhere around gcc 4.0, and probably doesn't exist in xlc at all. But now that we've agreed to toss xlc support out the window, there doesn't seem to be a reason not to go this way. In passing, I got rid of LONGALIGN[_DOWN] along with the configure probes for ALIGNOF_LONG. We were not using those anywhere and it seems highly unlikely that we'd do so in future. Instead supply INT64ALIGN[_DOWN], which isn't used either but at least could have a good reason to be used. Discussion: https://postgr.es/m/1127261.1769649624@sss.pgh.pa.us
55 lines
1.7 KiB
C
55 lines
1.7 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* pg_foreign_table.h
|
|
* definition of the "foreign table" system catalog (pg_foreign_table)
|
|
*
|
|
* Portions Copyright (c) 1996-2026, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/catalog/pg_foreign_table.h
|
|
*
|
|
* NOTES
|
|
* The Catalog.pm module reads this file and derives schema
|
|
* information.
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PG_FOREIGN_TABLE_H
|
|
#define PG_FOREIGN_TABLE_H
|
|
|
|
#include "catalog/genbki.h"
|
|
#include "catalog/pg_foreign_table_d.h" /* IWYU pragma: export */
|
|
|
|
/* ----------------
|
|
* pg_foreign_table definition. cpp turns this into
|
|
* typedef struct FormData_pg_foreign_table
|
|
* ----------------
|
|
*/
|
|
BEGIN_CATALOG_STRUCT
|
|
|
|
CATALOG(pg_foreign_table,3118,ForeignTableRelationId)
|
|
{
|
|
Oid ftrelid BKI_LOOKUP(pg_class); /* OID of foreign table */
|
|
Oid ftserver BKI_LOOKUP(pg_foreign_server); /* OID of foreign server */
|
|
|
|
#ifdef CATALOG_VARLEN /* variable-length fields start here */
|
|
text ftoptions[1]; /* FDW-specific options */
|
|
#endif
|
|
} FormData_pg_foreign_table;
|
|
|
|
END_CATALOG_STRUCT
|
|
|
|
/* ----------------
|
|
* Form_pg_foreign_table corresponds to a pointer to a tuple with
|
|
* the format of pg_foreign_table relation.
|
|
* ----------------
|
|
*/
|
|
typedef FormData_pg_foreign_table *Form_pg_foreign_table;
|
|
|
|
DECLARE_TOAST(pg_foreign_table, 4153, 4154);
|
|
|
|
DECLARE_UNIQUE_INDEX_PKEY(pg_foreign_table_relid_index, 3119, ForeignTableRelidIndexId, pg_foreign_table, btree(ftrelid oid_ops));
|
|
|
|
MAKE_SYSCACHE(FOREIGNTABLEREL, pg_foreign_table_relid_index, 4);
|
|
|
|
#endif /* PG_FOREIGN_TABLE_H */
|