postgresql/src/port
Tom Lane 3f35526479 Don't try to trim "../" in join_path_components().
join_path_components() tried to remove leading ".." components from its
tail argument, but it was not nearly bright enough to do so correctly
unless the head argument was (a) absolute and (b) canonicalized.
Rather than try to fix that logic, let's just get rid of it: there is no
correctness reason to remove "..", and cosmetic concerns can be taken
care of by a subsequent canonicalize_path() call.  Per bug #6715 from
Greg Davidson.

Back-patch to all supported branches.  It appears that pre-9.2, this
function is only used with absolute paths as head arguments, which is why
we'd not noticed the breakage before.  However, third-party code might be
expecting this function to work in more general cases, so it seems wise
to back-patch.

In HEAD and 9.2, also make some minor cosmetic improvements to callers.
2012-07-05 17:16:36 -04:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
chklocale.c Fix MinGW build, broken by my previous patch to add a setlocale() wrapper 2011-09-01 14:04:19 +03:00
crypt.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
dirent.c Avoid including postgres.h in frontend compiles of src/port. 2011-02-04 13:11:53 -05:00
dirmod.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
erand48.c Fix typo in pg_srand48 (srand48 in older branches). 2011-09-03 16:17:39 -04:00
exec.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
fseeko.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
getaddrinfo.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
gethostname.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
getopt.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
getopt_long.c Remove optreset from src/port/ implementations of getopt and getopt_long. 2010-12-16 16:23:05 -05:00
getpeereid.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
getrusage.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
gettimeofday.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
inet_aton.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
inet_net_ntop.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
isinf.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
kill.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
Makefile Move pipe.c into the backend. 2011-02-04 15:52:21 -05:00
memcmp.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
noblock.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
open.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
path.c Don't try to trim "../" in join_path_components(). 2012-07-05 17:16:36 -04:00
pgcheckdir.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
pgmkdirp.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
pgsleep.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
pgstrcasecmp.c Fix up handling of C/POSIX collations. 2011-03-20 12:44:13 -04:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort_arg.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
random.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
README Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
rint.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
snprintf.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
sprompt.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
srandom.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
strdup.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcpy.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
strtol.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
strtoul.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
thread.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
unsetenv.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
win32.ico Add as binary mode 2004-10-07 13:59:45 +00:00
win32env.c Stamp copyrights for year 2011. 2011-01-01 13:18:15 -05:00
win32error.c Avoid including postgres.h in frontend compiles of src/port. 2011-02-04 13:11:53 -05:00
win32setlocale.c Fix MinGW build, broken by my previous patch to add a setlocale() wrapper 2011-09-01 14:04:19 +03:00
win32ver.rc Stamp 9.1.4. 2012-05-31 19:07:09 -04:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Win32, Linux, and Darwin use an export list to
control the symbols exported by libpq.