mirror of
https://github.com/postgres/postgres.git
synced 2026-02-12 23:33:27 -05:00
a70f2a57f2
checkExtensionMembership() set the DUMP_COMPONENT_SECLABEL and DUMP_COMPONENT_POLICY flags for extension member objects, even though we lack any infrastructure for tracking extensions' initial settings of these properties. This is not OK. The result was that a dump would always include commands to set these properties for extension objects that have them, with at least three negative consequences: 1. The restoring user might not have privilege to set these properties on these objects. 2. The properties might be incorrect/irrelevant for the version of the extension that's installed in the destination database. 3. The dump itself might fail, in the case of RLS properties attached to extension tables that the dumping user lacks privilege to LOCK. (That's because we must get at least AccessShareLock to ensure that we don't fail while trying to decompile the RLS expressions.) When and if somebody cares to invent initial-state infrastructure for extensions' RLS policies and security labels, we could think about finding another way around problem #3. But in the absence of such infrastructure, this whole thing is just wrong and we shouldn't do it. (Note: this applies only to ordinary dumps; binary-upgrade dumps still dump and restore extension member objects separately, with all properties.) Tom Lane and Jacob Champion. Back-patch to all supported branches. Discussion: https://postgr.es/m/00d46a48-3324-d9a0-49bf-e7f0f11d1038@timescale.com |
||
|---|---|---|
| .. | ||
| po | ||
| t | ||
| .gitignore | ||
| common.c | ||
| compress_gzip.c | ||
| compress_gzip.h | ||
| compress_io.c | ||
| compress_io.h | ||
| compress_lz4.c | ||
| compress_lz4.h | ||
| compress_none.c | ||
| compress_none.h | ||
| compress_zstd.c | ||
| compress_zstd.h | ||
| dumputils.c | ||
| dumputils.h | ||
| Makefile | ||
| meson.build | ||
| nls.mk | ||
| parallel.c | ||
| parallel.h | ||
| pg_backup.h | ||
| pg_backup_archiver.c | ||
| pg_backup_archiver.h | ||
| pg_backup_custom.c | ||
| pg_backup_db.c | ||
| pg_backup_db.h | ||
| pg_backup_directory.c | ||
| pg_backup_null.c | ||
| pg_backup_tar.c | ||
| pg_backup_tar.h | ||
| pg_backup_utils.c | ||
| pg_backup_utils.h | ||
| pg_dump.c | ||
| pg_dump.h | ||
| pg_dump_sort.c | ||
| pg_dumpall.c | ||
| pg_restore.c | ||