mirror of
https://github.com/postgres/postgres.git
synced 2026-07-09 09:41:00 -04:00
1fbe2066dc
Presently, refint stores plans in a per-backend cache to avoid
re-preparing in each call. This has a few problems. For one,
check_foreign_key() embeds the new key values in its cascade-UPDATE
queries, so a cached plan reuses the values from preparation.
Also, the cache is never invalidated, so it can return stale
entries that cause other problems. There may very well be more
bugs lurking.
We could spend a lot of time trying to address all these problems,
but this module is primarily intended as sample code, and by all
indications, it sees minimal use. Furthermore, there is a growing
consensus for removing refint in v20. However, since we'll need to
support it on the back-branches for a while longer, it probably
still makes sense to fix some of the more egregious bugs.
Therefore, let's just remove refint's plan cache entirely. That
means we'll re-prepare on every call, but that seems quite unlikely
to bother anyone. On v17 and older versions, the regression test
for triggers fails after this change, so I've borrowed pieces of
commit
|
||
|---|---|---|
| .. | ||
| expected | ||
| sql | ||
| .gitignore | ||
| autoinc--1.0.sql | ||
| autoinc.c | ||
| autoinc.control | ||
| autoinc.example | ||
| insert_username--1.0.sql | ||
| insert_username.c | ||
| insert_username.control | ||
| insert_username.example | ||
| Makefile | ||
| meson.build | ||
| moddatetime--1.0.sql | ||
| moddatetime.c | ||
| moddatetime.control | ||
| moddatetime.example | ||
| refint--1.0.sql | ||
| refint.c | ||
| refint.control | ||
| refint.example | ||