mirror of
https://github.com/postgres/postgres.git
synced 2026-02-17 17:55:04 -05:00
409f9ca447
During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not being reset on transaction abort, but only on the follow-up command received by the WAL sender that created this snapshot on replication slot creation. This would trigger inconsistency failures if this session tried to export again a snapshot, like during the creation of a replication slot. Note that a snapshot export cannot happen in a transaction block, so there is no need to worry resetting this state for subtransaction aborts. Also, this inconsistent state would very unlikely show up to users. For example, one case where this could happen is an out-of-memory error when building the initial snapshot to-be-exported. Dilip found this problem while poking at a different patch, that caused an error in this code path for reasons unrelated to HEAD. Author: Dilip Kumar Reviewed-by: Michael Paquier, Zhihong Yu Discussion: https://postgr.es/m/CAFiTN-s0zA1Kj0ozGHwkYkHwa5U0zUE94RSc_g81WrpcETB5=w@mail.gmail.com Backpatch-through: 9.6 |
||
|---|---|---|
| .. | ||
| backup_manifest.h | ||
| basebackup.h | ||
| decode.h | ||
| logical.h | ||
| logicallauncher.h | ||
| logicalproto.h | ||
| logicalrelation.h | ||
| logicalworker.h | ||
| message.h | ||
| origin.h | ||
| output_plugin.h | ||
| pgoutput.h | ||
| reorderbuffer.h | ||
| slot.h | ||
| snapbuild.h | ||
| syncrep.h | ||
| walreceiver.h | ||
| walsender.h | ||
| walsender_private.h | ||
| worker_internal.h | ||