Tom Lane f2c6e94f07 Rethink recent fix for pg_dump's handling of extension config tables. ... Commit 3eb3d3e78 was a few bricks shy of a load: while it correctly set the table's "interesting" flag when deciding to dump the data of an extension config table, it was not correct to clear that flag if we concluded we shouldn't dump the data. This led to the crash reported in bug #16655, because in fact we'll traverse dumpTableSchema anyway for all extension tables (to see if they have user-added seclabels or RLS policies). The right thing to do is to force "interesting" true in makeTableDataInfo, and otherwise leave the flag alone. (Doing it there is more future-proof in case additional calls are added, and it also avoids setting the flag unnecessarily if that function decides the table is non-dumpable.) This investigation also showed that while only the --inserts code path had an obvious failure in the case considered by 3eb3d3e78, the COPY code path also has a problem with not having loaded table subsidiary data. That causes fmtCopyColumnList to silently return an empty string instead of the correct column list. That accidentally mostly works, which perhaps is why we didn't notice this before. It would only fail if the restore column order is different from the dump column order, which only happens in weird inheritance cases, so it's not surprising nobody had hit the case with an extension config table. Nonetheless, it's a bug, and it goes a long way back, not just to v12 where the --inserts code path started to have a problem with this. In hopes of catching such cases a bit sooner in future, add some Asserts that "interesting" has been set in both dumpTableData and dumpTableSchema. Adjust the test case added by 3eb3d3e78 so that it checks the COPY rather than INSERT form of that bug, allowing it to detect the longer-standing symptom. Per bug #16655 from Cameron Daniel. Back-patch to all supported branches. Discussion: https://postgr.es/m/16655-5c92d6b3a9438137@postgresql.org Discussion: https://postgr.es/m/18048b44-3414-b983-8c7c-9165b177900d@2ndQuadrant.com		2020-10-07 12:51:05 -04:00
..
backend	Fix two latent(?) bugs in equivclass.c.	2020-10-05 13:15:39 -04:00
bin	Rethink recent fix for pg_dump's handling of extension config tables.	2020-10-07 12:51:05 -04:00
common	Replace use of sys_siglist[] with strsignal().	2020-07-15 22:05:12 -04:00
fe_utils	Fix translation of special characters in psql's LaTeX output modes.	2018-11-26 17:32:51 -05:00
include	Fix bogus cache-invalidation logic in logical replication worker.	2020-09-16 12:07:31 -04:00
interfaces	Teach libpq to handle arbitrary-length lines in .pgpass files.	2020-09-01 13:14:44 -04:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
pl	Fix incorrect assertion on number of array dimensions.	2020-10-01 11:50:41 +03:00
port	Stamp 11.9.	2020-08-10 17:17:40 -04:00
template	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
test	Rethink recent fix for pg_dump's handling of extension config tables.	2020-10-07 12:51:05 -04:00
timezone	Ensure that distributed timezone abbreviation files are plain ASCII.	2020-07-17 11:04:36 -04:00
tools	Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.	2020-06-08 20:02:56 -07:00
tutorial	Update copyright for 2018	2018-01-02 23:30:12 -05:00
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	2010-09-22 12:57:04 +02:00
DEVELOPERS	Replace a couple of references to files that no longer exist in the source	2009-05-04 08:08:47 +00:00
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00