upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-03-08 00:01:15 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
postgresql/src/include/nodes
History
Peter Eisentraut fbc93b8b5f Remove custom Constraint node read/write implementations 
This is part of an effort to reduce the number of special cases in the
automatically generated node support functions.

Allegedly, only certain fields of the Constraint node are valid based
on contype.  But this has historically not been kept up to date in the
read/write functions.  The Constraint node is only used for debugging
DDL statements, so there are no strong requirements for its output,
and there is no enforcement for its correctness.  (There was no read
support before a6bc3301925.)  Commits e7a552f303 and abf46ad9c7 are
examples of where omissions were fixed.

This patch just removes the custom read/write implementations for the
Constraint node type.  Now we just output all the fields, which is a
bit more than before, but at least we don't have to maintain these
functions anymore.  Also, we lose the string representation of the
contype field, but for this marginal use case that seems tolerable.
This patch also changes the documentation of the Constraint struct to
put less emphasis on grouping fields by constraint type but rather
document for each field how it's used.

Reviewed-by: Paul Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://www.postgresql.org/message-id/flat/4b27fc50-8cd6-46f5-ab20-88dbaadca645@eisentraut.org
2024-02-22 07:07:12 +01:00
..
.gitignore Automatically generate node support functions 2022-07-09 08:53:59 +02:00
bitmapset.h Fix broken Bitmapset optimization in DiscreteKnapsack() 2024-01-19 10:44:36 +13:00
execnodes.h Add soft error handling to some expression nodes 2024-01-24 15:04:33 +09:00
extensible.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
lockoptions.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
makefuncs.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
memnodes.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
meson.build Update copyright for 2024 2024-01-03 20:49:05 -05:00
miscnodes.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
multibitmapset.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
nodeFuncs.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
nodes.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
params.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
parsenodes.h Remove custom Constraint node read/write implementations 2024-02-22 07:07:12 +01:00
pathnodes.h Add better handling of redundant IS [NOT] NULL quals 2024-01-23 18:09:18 +13:00
pg_list.h Add macros for looping through a List without a ListCell. 2024-01-04 16:09:34 -06:00
plannodes.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
primnodes.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
print.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
queryjumble.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
readfuncs.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
replnodes.h Allow setting failover property in the replication command. 2024-01-29 09:37:23 +05:30
subscripting.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
supportnodes.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
tidbitmap.h Update copyright for 2024 2024-01-03 20:49:05 -05:00
value.h Update copyright for 2024 2024-01-03 20:49:05 -05:00